Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have a list of files with filenames that sometimes only match the beginning of the title of entity they belong to so I thought it can be a nice addition to be able to choose the operator used for the search when using the entity_lookup process plugin.
Comment | File | Size | Author |
---|---|---|---|
#20 | 3121204-6.0.x-20.patch | 8.66 KB | Matroskeen |
#18 | 3121204-18.patch | 8.6 KB | Matroskeen |
Issue fork migrate_plus-3121204
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rodrigoaguileraHere is a simple patch to demonstrate what I am referring to
Comment #4
rodrigoaguileraIt that a real failure?
Comment #5
rodrigoaguileraI include the patch for the 4.2 version for project that haven't updated yet
Comment #6
rodrigoaguilerawell, it doesn't apply to 4,x, only to 4.2.
Back to 5.x where is relevant
Comment #8
rodrigoaguileraOpened a MR to get some attention
Comment #9
heddnComment #10
MatroskeenLet's try to address feedback in the merge request and add a test coverage.
Comment #11
MatroskeenI put some test coverage for the new
operator
property, but it fails because of these lines:In the test example,
$result_value
islucuma
and$value
islucu
.That's why the result is removed.
Why do we have this? I haven't looked at the commit history yet. Perhaps the answer is there.
Comment #12
MatroskeenI published a few more commits - it's ready for review.
Comment #14
MatroskeenI self-reviewed it today and decided to go ahead and commit. If there are any suggestions/concerns, we can move them into a follow-up.
I'll also keep it open for backporting to 6.0 during the weekend so there is an opportunity to discuss if we can make it better.
Thanks!
Comment #15
MatroskeenI don't know what happened After #12, but all tests are failing now. Trying a patch to add missing return types.
Comment #16
MatroskeenOps, wrong file
Comment #17
MatroskeenI reverted the last commit until we fix the test bot results.
Comment #18
MatroskeenSince I can't figure out why the test results are not showing up, but the tests are passing (we can see it in the job details), here is a new patch that contains MR changes + #16.
Comment #20
MatroskeenHere is a patch for 6.0.x version
Comment #22
MatroskeenAlthough the message is "Build Successful", the tests are passing according to the Test Report.
This is committed to 8.x-5.x and 6.0.x.
Thanks!