Problem/Motivation

I was not able to replicate "Display analysis for all content types which has webform field." from #3014657: Allow to display analysis for all content types but
"Display analysis for each webform in the content type which has multiple webform fields." is supported by the core Webform module.

Proposed resolution

Use the \Drupal\webform\WebformRequest to determine the current requests webform and source entity.

I will also fix the webform node module to display the switch webform field drop down on the 'Analysis' tab.

Remaining tasks

  • Write patch
  • Review patch
  • Commit patch

User interface changes

Switch webform field drop down on the 'Analysis' tab.

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#7 webform_analysis-3120286-7.patch619 bytesbatigolix
#2 webform_analysis-3120286-2.patch613 bytesjrockowitz
webform-analysis-node-multiple.png187.09 KBjrockowitz

Issue fork webform_analysis-3120286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new webform_analysis-3120286-2.patch613 bytes
llewellyn.dawson’s picture

llewellyn.dawson commented
Assigned: Unassigned » llewellyn.dawson
llewellyn.dawson’s picture

llewellyn.dawson commented
Status: Needs review » Needs work

Tried to apply the patch and it did not work

error: patch failed: src/WebformAnalysis.php:29
error: src/WebformAnalysis.php: patch does not apply
llewellyn.dawson’s picture

llewellyn.dawson commented
Assigned: llewellyn.dawson » Unassigned
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +finalist-sprint
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs work » Needs review
StatusFileSize
new webform_analysis-3120286-7.patch619 bytes

I updated the patch so that it can be tested.

ankitv18’s picture

ankitv18 commented

Can we have a MR for this issue so that we the changes will pass all GitLab CI checks

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

This has already been is addressed via another ticket

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.