Closed (fixed)
Project:
Cookie Content Blocker
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2020 at 15:28 UTC
Updated:
29 Jun 2020 at 06:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
idebr commentedAttached patch applies Drupal core coding standards to composer.json
Comment #3
steven buteneers commentedI'm not sure what went wrong but this patch does not apply properly. Authors are suddenly added outside of the "authors" property.
Also punctuation is broken.
Comment #4
idebr commentedWhat command are you using to apply the patch? Is the command reporting any errors?
Comment #5
steven buteneers commentedHi idebr,
Just a regular git apply. But if you take a look at the patch yourself you can clearly see the problem.
Comment #6
anybodyWouldn't it be better to completely remove the composer.json file? It's being created automatically by Drupal.org and adding it manual adds the risk to be different from info.yml.
Comment #7
dmsmidt@Anybody, interesting, where is that documented?
Not here: https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file
Comment #8
anybody@dmsmidt: SORRY! -.- I was wrong, you're right! I'm not sure how I got to that conclusion but I guess because of the compatibility information checked by composer when you require a new project (core compatibility). Sorry for the confusion and my stupid mistake!
Anyway I guess the composer.yml in this projects prevents it from (composer) Drupal 9 compatibility so marking this related: #3150122: composer.json is not Drupal 9 compatible
I guess we can use the same string as in the .info.yml?
For that #2 would also need work.
Comment #9
anybodyReroll of #2 attached with interdiff. Please review.
Comment #10
mrpauldriver commentedI unable to the install the module with composer on a D9 site. I also have the patch at #9 in my composer.json (using cweagans/composer-patches).
The backtrace is quite lengthy, so please take a look at this Pastebin.
Comment #12
steven buteneers commentedThank for reporting this issue and providing the patch.
I committed the changes.