Closed (fixed)
Project:
Block Content Permissions
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2020 at 09:29 UTC
Updated:
4 Jun 2020 at 04:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
pavnish commentedComment #3
gambryLooks good. Thanks!
Comment #4
heddn+1 on RTBC. Did a quick manual check of the code. There isn't any composer.json. No version specific code in here; so it looks like it can run on 8.x and 9.x of Drupal core without any hackery.
Comment #5
gaurav_drupalto │
│ manually │ │ block_content_permissions.info.yml to designate that the │
│ │ │ module is compatible with Drupal 9. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────┘
Comment #6
gaurav_drupalProvided the patch, please review.
Comment #7
gaurav_drupalComment #8
piggito commentedI checked last patch with drupal-check, Upgrade Status and Drupal Rector and it passed for all 3 tools so I'm adding RTBC
Comment #9
pavnish commented@Gaurav_drupal @piggito Thanks but the bug about only for "Add core version requirement support for drupal 9"
Add deprecation in this issue is not a good thing.
Comment #10
gambryThat's fine @pavnish . We just need to update the Issue Summary to state this is for Drupal 9 compatibility.
Comment #11
pavnish commentedComment #12
pavnish commented@gambry Thanks
I have updated the issue summary.
Thanks
Pavnish
Comment #13
mohammed j. razem+1
Looks good! I have sent the maintainer joshua.roberson to urge a commit/release.
Comment #15
joshua.roberson commentedThis is on dev now.
Comment #16
joshua.roberson commented