Problem/Motivation

There is a conflict between search_autocomplete module and views_autocomplete_filters.

Both override Drupal.autocomplete.options.select and thus override each other.

See the files:

  • views_autocomplete_filters/js/views-autocomplete-filters.js
  • search_autocomplete/js/jquery.autocomplete.js

Proposed resolution

Remove the library. This library is no longer needed since #2864807: Autocomplete textfield surrounds titles with double quotes got in.

Remaining tasks

Review the patch and apply it.

User interface changes

None.

API changes

Removed one library from the module.

Data model changes

None.

Release notes snippet

TBD

CommentFileSizeAuthor
#4 3117099-4.patch2.18 KBmanuel garcia

Issue fork views_autocomplete_filters-3117099

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Manuel Garcia created an issue. See original summary.

manuel garcia’s picture

manuel garcia commented

For anyone that runs into this, you could in your theme's info file do this to disable the offending library.

# See https://www.drupal.org/project/views_autocomplete_filters/issues/3117099
libraries-override:
  views_autocomplete_filters/drupal.views-autocomplete-filters: false
manuel garcia’s picture

manuel garcia commented
Related issues: +#2852442: Autocomplete suggestion adds quotes to result

Adding the issue where this file was introduced.

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new 3117099-4.patch2.18 KB

On #2864807: Autocomplete textfield surrounds titles with double quotes core removed the quotes from autocomplete results so we do not need to do this on this module any longer.

This patch removes the library that does it.

manuel garcia’s picture

manuel garcia commented
Issue summary: View changes
vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs review » Needs work

It seems there could be a related issue and its patch ...

So added as related issue to be taken into account ...

put it back in "Needs work" to make sure about related issue

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs work » Needs review

Please don't create deadlock by setting a collection of independent issues to NW.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Category: Bug report » Task
Status: Needs review » Needs work

it seems the core issue was "done" some time ago ... so maybe we could clean-up here.

update the branch and I'll create a MR as the patch doesn't apply anymore.

vasike opened merge request !15

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs work » Needs review

MR created.

  • vasike committed 5c26eea9 on 2.0.x 
    Issue #3117099 by Manuel Garcia, vasike: Remove drupal.views-...
vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs review » Fixed

and merged
thanks a lot @Manuel Garcia ... sorry for delay ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.