Prevent customer order comments from setting a 'completed' status

Hello philsward.
I believe that you are not working correctly with ubercart. You want to leave comments for the order, but it should to change the status of the order. function uc_order_comment_save() not related to change of order status, and this function does not allow changing the order status.
You can see all order's status on page example.com/admin/store/settings/orders/workflow.
PS. I had same problem with customers, then i added webhook to code. I will add path for it in over issue

function uc_stripe_charge
if stripe doesn't return Exception then function return array from line 659

    $result = array(
      'success' => TRUE,
      'message' => t('Payment of @amount processed successfully, Stripe transaction id @transaction_id.', array('@amount' => $formatted_amount, '@transaction_id' => $charge_id)),
      'comment' => t('Stripe transaction ID: @transaction_id', array('@transaction_id' => $charge_id)),
      'uid' => $user->uid,
    );

property 'success' => TRUE is Important!

Function uc_stripe_charge is declared in uc_stripe_uc_payment_gateway. This hook calls from function _uc_payment_gateway_list file uc_payment.module. Function _uc_payment_gateway_list() calls from frunction uc_payment_process_payment().
Important part code for us from uc_payment_process_payment().

  // Check to see if the function exists and process the payment.
  if (function_exists($gateway[$method])) {
    // Reset the entity cache, so the latest data saved in the credit card cache
    // is guaranteed to be available in the charge function.
    uc_order_load($order_id, TRUE);

    $result = $gateway[$method]($order_id, $amount, $data);
  }
  else {
    // Otherwise display an error message to administrators.
    $result['success'] = FALSE;
    $result['message'] = t('An error has occurred with your payment gateway. The charge function could not be found.');
    if (user_access('administer store')) {
      drupal_set_message($result['message']);
    }
  }

  // If the payment processed successfully...
  if ($result['success'] === TRUE) {
    // Log the payment to the order if not disabled.
    if (!isset($result['log_payment']) || $result['log_payment'] !== FALSE) {
      uc_payment_enter($order_id, $method, $amount, empty($result['uid']) ? 0 : $result['uid'], empty($result['data']) ? '' : $result['data'], empty($result['comment']) ? '' : $result['comment']);
    }
  }

This line
uc_payment_enter($order_id, $method, $amount, empty($result['uid']) ? 0 : $result['uid'], empty($result['data']) ? '' : $result['data'], empty($result['comment']) ? '' : $result['comment']);
confirms the payment. Enters payment for an order to your store. and then ubercart changes status of order to "Payment received".
Comment does not enter payment into order.

I saw images, got it.
Then I suggest patch.

@philsward

Honestly, I believe you can just remove
uc_order_comment_save($order_id, $user->uid, $result['message'], 'order', 'completed', FALSE);

And be fine.

From my recollection ubercart has a rule to check if balance is 0, and if the order doesn't require shipping. If both those conditions are good then it sets it to complete. Otherwise, the site owners can modify the status manually when ready.

Please test it and let us know. Based on version 3.3 version, it's the one at line 667.

I can see why it caused a lot of confusion. I wasn't quite getting the point before, sorry about that. There is no reason to confuse the customers by setting a comment saying "completed" when uc_stripe only collects payment.

I think changing

uc_order_comment_save($order_id, $user->uid, $result['message'], 'order', 'completed', FALSE);
to
uc_order_comment_save($order_id, $user->uid, $result['message'], 'order', 'payment_received', FALSE);

is the best solution.

It doesn't interfere with any of the normal behavior of ubercart or uc_stripe.

I can fast track this since you have tested it for 6 months already.

Also this works fine for non-shippable orders as well. It sets the comment status to payment received and the default ubercart rules will do the rest.

To give some clarification Philsward, I believe you were using the module correctly.

After a payment is successful, this file has a rule that sets the overall order status to payment received if balance is 0, or to completed if balance is 0 and there is nothing to ship.

ubercart/payment/uc_payment/uc_payment.rules_defaults.inc

The uc_order_comment_save function simply adds a comment to the order comments or admin order comments database and that status indicates the status the comment is related to.