Can't add new registrants when registering for an event

Here is the patch to above mentioned bug fix.

I can confirm that this patch fixes this problem.

Can we commit this then ?

Using D8.8.3
Put patch#1 and solve problem on seeing register tab,
(I think it will be the same for line 623, same code problem)

but when saving registration, this error occurs:
Error: Call to undefined method Drupal\rng\EventMeta::getCapacity() in Drupal\rng\EventSubscriber\RegistrationWaitListSubscriber->onRegistrationInsert() (line 64...

Solved changing 'getCapacity()' - does not exist - with 'getRegistrationCapacity()'

Hope it helps

Hi,

Thank you for the patch! I think the issue is fixed through a bunch of other work I had on a local branch -- including some refactoring of the various capacity methods. I'm not sure that's entirely done, but this is no longer an issue...

Cheers,
John

I can confirm that I'm seeing the originally reported error using RNG 3.0.0-alpha1 with Drupal 8.9.1 with a content type as the Event Type in RNG.

The patch does allow the "Register" tab to render properly, but as reported in #5 trying to save your registration throws the additional error:

Error: Call to undefined method Drupal\rng\EventMeta::getCapacity() in Drupal\rng\EventSubscriber\RegistrationWaitListSubscriber->onRegistrationInsert() (line 64 of /Users/martin/Sites/drupal_qa/web/modules/contrib/rng/src/EventSubscriber/RegistrationWaitlistSubscriber.php)

The fix described in #5 also still works.

Even with this patch applied I see a notice when the Register tab renders:

Notice: Undefined property: Drupal\Core\Entity\EntityTypeBundleInfo::$label in Drupal\rng\Element\Registrants::processIdentityElement() (line 182 of /Users/martin/Sites/drupal_qa/web/modules/contrib/rng/src/Element/Registrants.php)

Also, if I click "Create new" under "New Registrant" the spinner shows briefly and then nothing happens. In the error log I see the notice above again, as well as:

TypeError: Argument 3 passed to Drupal\rng\Form\RegistrantFields::__construct() must implement interface Drupal\rng\Entity\RegistrantInterface or be null, array given, called in /Users/martin/Sites/drupal_qa/web/modules/contrib/rng/src/Element/Registrants.php on line 150 in Drupal\rng\Form\RegistrantFields->__construct() (line 39 of /Users/martin/Sites/drupal_qa/web/modules/contrib/rng/src/Form/RegistrantFields.php)

After some additional testing, I think (on 3.0.0-alpha1 at least) the patch only changes the error from a fatal error into a notice, but doesn't actually fix the intended behaviour.

$bundle_info is an instance of Drupal\Core\Entity\EntityTypeBundleInfo, so it can be used to load an array of labels for a particular entity type. I'm very new to RNG so I don't entirely follow what's meant to be used here, but I suspect it should actually be leveraging something further down, in a different conditional branch:

        /** @var \Drupal\rng\RegistrantFactoryInterface $registrant_factory */
        $registrant_factory = \Drupal::service('rng.registrant_factory');
        $new_person = $registrant_factory->createRegistrant([
          'event' => $event,
        ]);
        $new_person
          ->setRegistration($registration);
        $display = $entity_display_repository->getFormDisplay('registrant', $new_person->bundle());
        $display->buildForm($new_person, $person_subform['new_person']['newentityform'], $form_state);

Is the "Create new" button meant to show the label from $new_person->bundle()?

I have just landed on this as well, without a fix in its current state this module is unusable, can we get to the bottom of this to get it working?

@freelock can you shed some light on this for the local branch you have been working on, I don't have enough exposure to the code to be able to give much help but willing to look at the code to help move this along.

Hi,

Sorry, I've got a long backlog of things in progress right now. We do have this working on a site right now, but there are a bunch of changes to the underlying code, and a couple areas with some specific hard-coded items that will need to get refactored some. I'll sort out the commits and push some working code to the dev branch in the next couple days...

I closed this as "Outdated" because the code throwing the error is no longer used at all.

Cheers,
John

@freelock You have a great looking module here, didn't work with it right now, but looks quite good already.

My customer wants a solution in the next two weeks for a registration for an upcoming event.
I know, you owe nobody anything or so and I'm very thankful for the work you are doing here!
Do you think it will be possible to use this module in version 3 in the next two weeks for a new event registration or should I better use the 1.x branch? Would be also willing to test new patches & branches - not sure I can provide much help on code side.

Greetings

Pushed up the code we've been working with, which does allow registrations.

This is still an issue in dev, should be reopened.

Can confirm that this is still an issue on the latest dev

Can confirm the original issue is still present on 3.0.0-alpha1 and 3.x-dev.

Can also confirm everything that is mentioned in #5 and #7 is present on both branches.

@freelock You mention in number 12 that the code you released is working on a site. Is one of the extra modules (e.g., rng_conflict, rng_date_scheduler) installed on that site and masking this issue there? I have nothing to back up that idea, it's just a thought :)

Just confirming that the error described by #7 is still present in 3.x-dev.

TypeError: Argument 3 passed to Drupal\rng\Form\RegistrantFields::__construct() must implement interface Drupal\rng\Entity\RegistrantInterface or be null, array given, called in /app/modules/contrib/rng/src/Element/Registrants.php on line 150 in Drupal\rng\Form\RegistrantFields->__construct() (line 39 of /app/modules/contrib/rng/src/Form/RegistrantFields.php)

A great pity that this project is not progressing.

@RogerB
Good news! I recently got added as a maintainer to this project and I'm trying to get it into a working state again. I noticed that registering doesn't work for me either, but I couldn't find a quick way to fix it yet. I'm thinking of refactoring the code in src/Element/Registrants.php a bit. I hope my client gives me enough time to look into this. This project blocks a site from upgrading it to D9 for me.

But first, I'm bug hunting on the API level, so I get more familiar with the code.

I had a poke at this yesterday. I splitted the code from \Drupal\rng\Element\Registrants::processIdentityElement() into multiple methods to make the code look less bloated. I saw something that I believed to be a bug, namely that $element['people'][]['registrant'] had the same #parents value as $element['people'][]. Fixing that did resolve the error reported in #18, but it still did not make adding new registrants working.

So as of now, I see no quick way to fix this issue. I'm thinking it would be better to rebuild the registration UI from scratch. I wasn't fan of how the UI looked like anyway.

But I think I won't get the time from my client to rebuild this registration UI, especially since we already use our own customized registration UI.

The patch is no longer relevant, so hiding that one.

I updated the issue summary.

@MegaChriz the Ticket module had a pretty slick UI but the D8 port seems to have stalled. If you're planning to rebuild the registration interface here, maybe draw some inspiration (or even some code?) from what had been implemented there?