We have a basic smoke test that does an export and import of a node, but we should also test export all and export referenced.

CommentFileSizeAuthor
#2 3114142-2.patch6.21 KBandyf
#5 interdiff_2-5.txt1.01 KBandyf
#5 3114142-5.patch6.4 KBandyf

Comments

AndyF created an issue. See original summary.

andyf’s picture

Status: Active » Needs review
StatusFileSize
new6.21 KB

This tests each command, if not extensively...

andyf’s picture

Assigned: andyf » Unassigned

Status: Needs review » Needs work

The last submitted patch, 2: 3114142-2.patch, failed testing. View results

andyf’s picture

Status: Needs work » Needs review
StatusFileSize
new6.4 KB
new1.01 KB

Oops, I forgot to sort the file listing in one test before asserting it, making it unreliable.

baysaa’s picture

Status: Needs review » Reviewed & tested by the community
Drupal test run
---------------
Tests to be run:
  - Drupal\Tests\contentserialize\Unit\TraversablesTest
  - Drupal\Tests\contentserialize\Unit\OptionsProviderTest
  - Drupal\Tests\contentserialize\Kernel\EntityReferenceRevisionsTest
  - Drupal\Tests\contentserialize\Kernel\TermTest
  - Drupal\Tests\contentserialize\Kernel\FileTest
  - Drupal\Tests\contentserialize\Kernel\MenuLinkContentTest
  - Drupal\Tests\contentserialize\Kernel\NodeTest
  - Drupal\Tests\contentserialize\Kernel\MetatagTest
  - Drupal\Tests\contentserialize\Functional\DrushCommandsTest
  - Drupal\Tests\bulkentity\Unit\EntityLoaderTest
  - Drupal\Tests\bulkentity\Kernel\EntityLoaderTest
Test run started:
  Tuesday, February 18, 2020 - 13:55
Test summary
------------
Drupal\Tests\contentserialize\Unit\TraversablesTest           13 passes                                      
Drupal\Tests\contentserialize\Unit\OptionsProviderTest        13 passes                                      
Drupal\Tests\contentserialize\Kernel\TermTest                  1 passes                                      
Drupal\Tests\contentserialize\Kernel\EntityReferenceRevision   1 passes                                      
Drupal\Tests\contentserialize\Kernel\FileTest                  1 passes                                      
Drupal\Tests\contentserialize\Kernel\MenuLinkContentTest       1 passes                                      
Drupal\Tests\bulkentity\Unit\EntityLoaderTest                  1 passes                                      
Drupal\Tests\contentserialize\Kernel\NodeTest                  1 passes                                      
Drupal\Tests\contentserialize\Kernel\MetatagTest               1 passes                                      
Drupal\Tests\bulkentity\Kernel\EntityLoaderTest                3 passes                                      
Drupal\Tests\contentserialize\Functional\DrushCommandsTest     3 passes

tests lgtm +1. Tested all pass. Is it ok to set RTBC? :)

  • AndyF committed 352243d on 8.x-1.x
    Issue #3114142 by AndyF, Baysaa: Test drush commands
    
andyf’s picture

Status: Reviewed & tested by the community » Fixed

Yup, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.