drupal-check docroot/modules/contrib/vmi

4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


                                                                                                                        
 [OK] No errors


Upgrade status


CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
View Modes Inventory 8.x-2.4
Scanned on Thu, 02/13/2020 - 16:00.

1 warning found.

#3113200: Drupal 9 Readiness for [VMI] with Drupal coding standard and practice

modules/contrib/vmi/vmi.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to       │
│ manually │      │ vmi.info.yml to designate that the module is compatible with │
│          │      │ Drupal 9. See https://www.drupal.org/node/3070687.           │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘




Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check VMI Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/

Check VMI Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/


Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Had to add

"drupal/core-dev": "^8.8"

and enable the Testing module
and It's [OK] No errors on the drupal-check

  • RajabNatshah committed 9ab3852 on 8.x-2.x
    Issue #3113200: Drupal 9 Readiness for [VMI] with Drupal coding standard...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.4, +varbase-8.9.0, +varbase-9.0.0
rajab@vardot-dev:/var/www/html/products/vmi$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/


rajab@vardot-dev:/var/www/html/products/vmi$ phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md /var/www/html/products/vmi/ --ignore=/var/www/html/products/vmi/node_modules/
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah’s picture

Issue tags: -varbase-9.0.0 +varbase-9.1.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah’s picture

Title: Drupal 9 Readiness for [VMI] with Drupal coding standard and practice » Drupal 9 compatibility for [VMI] with Drupal coding standard and practice
Issue tags: -Drupal 9 readiness, -varbase-8.9.0