Hello, I've been tasked with evaluating a set of modules for Drupal 9 readiness, and this one is on my list. Does anyone know if this module needs any changes for Drupal 9?

CommentFileSizeAuthor
#8 Screenshot 1942-06-31 at 12.39.56 PM.png15.87 KBgauravvvv
#3 3112600-3.patch287 bytesdeepak goyal

Comments

jenlampton created an issue. See original summary.

deepak goyal’s picture

deepak goyal commented
Assigned: Unassigned » deepak goyal
Issue tags: -Drupal 9 compatibility +Drupal 9 compatibility Drupal 9 porting weekend DIACWMay2020
deepak goyal’s picture

deepak goyal commented
Status: Active » Needs review
StatusFileSize
new 3112600-3.patch287 bytes

Update core requirement please review the patch.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -Drupal 9 compatibility Drupal 9 porting weekend DIACWMay2020 +Drupal 9 compatibility, +Drupal 9 porting weekend, +DIACWMay2020

Fixing tags.

deepak goyal’s picture

deepak goyal commented
Assigned: deepak goyal » Unassigned
meghasharma’s picture

meghasharma commented
Assigned: Unassigned » meghasharma
meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +DIACWSep2020

#3 patch applied cleanly..
Have run drupal-check & rector tools and scanned upgrade_status on follow module: No errors reported.
it looks good to me..
marking as RTBC

my_site_name_dir % vendor/bin/rector process web/modules/contrib/follow --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                                      
 [OK] Rector is done!                                                                                                   
                                                                                                                        
my_site_name_dir % vendor/bin/drupal-check -ad web/modules/contrib/follow                        
 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                                      
 [OK] No errors
gauravvvv’s picture

gauravvvv commented
StatusFileSize
new Screenshot 1942-06-31 at 12.39.56 PM.png15.87 KB

Patch #3 works fine for me RTBC+1, Adding screenshot for ref.

astonvictor’s picture

astonvictor commented
Status: Reviewed & tested by the community » Closed (duplicate)

It's a duplicate of #3140589: Automated Drupal Rector fixes