[D8] Google Ad Manager Workspace [#3111934]

This module aims to make adding Google Ads to any Drupal 8 website a simple and effective process. It removes the need for any boilerplate JS or HTML code that is required by Google Ad Manager and allows you to handle everything from the UI.

This module can be used by even the most inexperienced Drupal users to successfully add Google Ads to their website while abiding by all coding standards set in the Google Ad Manager documentation.

While solutions like these already exist they do not offer the amount of customization, ad targeting and ease of use this module offers.
The most similar project I could find was https://www.drupal.org/project/ad_manager but only has a Drupal 7 version.

Project link

https://www.drupal.org/project/gamw

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/gamw.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-gamw.git

Comment	File	Size	Author
	module-configuration-form.png	109.18 KB	eliaspapa
	block-configuration-form.png	82.07 KB	eliaspapa

Comments

Comment #1

7 February 2020 at 13:56

EliasPapa created an issue. See original summary.

Comment #2

eliaspapa commented 7 February 2020 at 13:57

Issue summary:

View changes

Comment #3

eliaspapa commented 7 February 2020 at 13:58

Issue summary:

View changes

Comment #4

phthlaap commented 7 February 2020 at 16:36

Issue summary:

View changes

Thanks for your contribution.
I added PAReview link, Please fix some issues reported:

/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 5, col 2, Error - Use the function form of 'use strict'. (strict)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 6, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 7, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 8, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 10, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 10, col 45, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 11, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 11, col 48, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 12, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 13, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 14, col 21, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 14, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 14, col 30, Error - 'key' used outside of binding context. (block-scoped-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 15, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 15, col 25, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 15, col 62, Error - 'key' used outside of binding context. (block-scoped-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 16, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 16, col 62, Error - 'key' used outside of binding context. (block-scoped-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 17, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 20, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 21, col 21, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 21, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 21, col 30, Error - 'key' used outside of binding context. (block-scoped-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 21, col 30, Error - 'key' is already defined. (no-redeclare)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 22, col 25, Error - Expected indentation of 22 spaces but found 24. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 22, col 53, Error - 'key' used outside of binding context. (block-scoped-var)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 25, col 21, Error - Expected indentation of 18 spaces but found 20. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 27, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 28, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 29, col 54, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 30, col 37, Error - Expected indentation of 34 spaces but found 36. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 31, col 37, Error - The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype. (guard-for-in)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 31, col 37, Error - Expected indentation of 34 spaces but found 36. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 32, col 41, Error - Expected indentation of 38 spaces but found 40. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 34, col 37, Error - Expected indentation of 34 spaces but found 36. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 37, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 39, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 39, col 84, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 39, col 114, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 39, col 154, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 40, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 40, col 49, Error - Expected '!==' and instead saw '!='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 40, col 52, Error - Unexpected use of undefined. (no-undefined)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 41, col 37, Error - Expected indentation of 30 spaces but found 36. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 42, col 37, Error - Expected indentation of 30 spaces but found 36. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 43, col 77, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 44, col 45, Error - Expected indentation of 42 spaces but found 44. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 47, col 39, Error - Expected indentation of 30 spaces but found 38. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 49, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 50, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 51, col 39, Error - Expected indentation of 30 spaces but found 38. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 53, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 54, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 54, col 59, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 55, col 29, Error - Expected indentation of 26 spaces but found 28. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 56, col 33, Error - Expected indentation of 30 spaces but found 32. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 56, col 33, Error - Unexpected console statement. (no-console)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 56, col 45, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Gamw.js: line 56, col 80, Error - Strings must use singlequote. (quotes)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 6, col 2, Error - Use the function form of 'use strict'. (strict)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 7, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 7, col 36, Error - Missing semicolon. (semi)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 8, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 9, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 10, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 11, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 12, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 13, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 13, col 18, Error - Expected literal to be on the right side of ==. (yoda)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 13, col 27, Error - Expected '===' and instead saw '=='. (eqeqeq)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 14, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 15, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/Necessary.js: line 16, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)

73 problems

Comment #5

phthlaap commented 7 February 2020 at 16:41

Status:

Needs review

» Needs work

Update to change Status to Need work

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 8 February 2020 at 09:31

Issue summary:

View changes

Comment #7

eliaspapa commented 10 February 2020 at 11:10

Status:

Needs work

» Needs review

Thank you @phthlaap and @kiamlaluno for your reviews!

I ran the .js files through eslint and also did some required manual changes and PAReview reports no issues now.
Setting this back to Needs review. Appreciate it.

Comment #8

phthlaap commented 23 February 2020 at 03:15

Thanks for your contribution!
I didn't see any security issues related to the code.

Comment #9

phthlaap commented 23 February 2020 at 03:15

Status:

Needs review

» Reviewed & tested by the community

Comment #10

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 23 February 2020 at 18:23

Assigned:	Unassigned	» avpaderno
Status:	Reviewed & tested by the community	» Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Comment #11

8 March 2020 at 18:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

[D8] Google Ad Manager Workspace

Project link

Git instructions

PAReview checklist

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

News items

Our community

Documentation

Drupal code base

Governance of community