Drupal 9 deprecated code report

20/20 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------------
  Line   src/EventSubscriber/ConfigSubscriber.php
 ------ ----------------------------------------------------------------------
  172    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src/Form/FieldEncryptUpdateForm.php
 ------ ----------------------------------------------------------------------
  171    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
  176    Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ -------------------------------------------------------------------------
  Line   tests/src/Unit/FieldEncryptProcessEntitiesTest.php
 ------ -------------------------------------------------------------------------
  162    Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase:
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Tests\PhpunitCompatibilityTrait::createMock() instead.
 ------ -------------------------------------------------------------------------                                                                                             

 [ERROR] Found 4 errors
CommentFileSizeAuthor
#18 3111904-16.png47.08 KBvijaycs85
#16 3111904-16.patch21.62 KBalexpott
#16 14-16-interdiff.txt1.29 KBalexpott
#14 3111904-14.patch22.69 KBalexpott
#8 3111904-8.patch16.21 KBdrupalviking
#8 interdiff_5_8.txt2.38 KBdrupalviking
#4 3111904-4.patch13.83 KBkir lazur
#3 3111904-3.patch12.47 KBkir lazur

Comments

drupalfox created an issue. See original summary.

kir lazur’s picture

kir lazur commented
Assigned: Unassigned » kir lazur
kir lazur’s picture

kir lazur commented
Status: Active » Needs review
StatusFileSize
new 3111904-3.patch12.47 KB

All mandatory fixes of deprecations in source code are done and tested.
I guess that test cases deprecations will require more attention and test actualization, probably me or someone can check them later.

kir lazur’s picture

kir lazur commented
StatusFileSize
new 3111904-4.patch13.83 KB

Updated version of patch.

Status: Needs review » Needs work

The last submitted patch, 4: 3111904-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jcnventura’s picture

jcnventura
Primary language English
commented
Issue tags: -

Also missing the core_version_requirements line in the module's .info.yml file.

drupalviking’s picture

drupalviking
he/him
commented
Assigned: kir lazur » drupalviking

Reviewing and fixing the last problems with failed tests.

drupalviking’s picture

drupalviking
he/him
commented
Assigned: drupalviking » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff_5_8.txt2.38 KB
new 3111904-8.patch16.21 KB

Fixed the last errors regarding deprecated function calls in the Test classes. Added dependency to Drupal 8.8 or higher.

jcnventura’s picture

jcnventura
Primary language English
commented
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend

Status: Needs review » Needs work

The last submitted patch, 8: 3111904-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Postponed

We should probably postpone this on #3124830: Fix project on Drupal ^8.7 and fix failing tests on 8.x-2.x. Since the tests are currently failing which makes it hard to check the compatibilty and some of the deprecations are already fixed in that issue.

suzymasri’s picture

suzymasri
Location Greece
commented

Patch #8 fixes all drupal-check errors.

#3142988: D9 readiness Should fix the failing D9 test, and the changes in #3124830: Fix project on Drupal ^8.7 and fix failing tests on 8.x-2.x will fix all other failing tests when released.

suzymasri’s picture

suzymasri
Location Greece
commented
Issue tags: +Needs reroll
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Postponed » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3111904-14.patch22.69 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented 
+++ b/composer.json
@@ -3,7 +3,7 @@
-        "drupal/core": "^8",
+        "drupal/core": "^8.7.7 || ^9",

This is the same the key module which is a dependency so seems fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 14-16-interdiff.txt1.29 KB
new 3111904-16.patch21.62 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

We can't run tests on D9 until this is committed because DrupalCI does things interesting ways around. tests pass on D9 locally.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue summary: View changes
StatusFileSize
new 3111904-16.png47.08 KB

I guess some of the deprecated issues fixed. we got 4 issues(updated in issue summary) in the current head and all of them fixed by the latest patch.
Only local images are allowed.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Thanks @vijaycs85

  • alexpott committed 4a50d90 on 8.x-2.x authored by Kiril Lazur 
    Issue #3111904 by alexpott, Kiril Lazur, drupalviking, vijaycs85,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.