Migrate Source CSV 8.3.2 requires League/CSV Version 9 and Drupal CSV Serialization version 1.0 uses League/CSV Version 8. I propose moving the requirement to CSV Serialization 2.0.

I've been using Beta 3 of Views Data export with CSV Serialization 2.0 for a while now and have had no issues creating and exporting data to csv format. I currently cannot update to Beta 4 while also using Migrate Source CSV version 3.

CommentFileSizeAuthor
#4 3111698-4.patch348 bytessvendecabooter
#3 3111698-3.patch345 bytessvendecabooter

Comments

emerham created an issue. See original summary.

ayalon’s picture

ayalon commented

I have the same experience.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
StatusFileSize
new 3111698-3.patch345 bytes

Encountering the same issue.
I think this patch should allow installation of both the 1.4 as well as the 2.0-beta version of csv_serialization module.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Active » Needs review
StatusFileSize
new 3111698-4.patch348 bytes

Updated patch, using the OR operator instead of AND, which makes more sense.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Since patches are only applied after resolving dependencies, this patch won't work on its own to resolve dependency resolution failures with Migrate Source CSV.

Composer Patches proposes the following work-around:

Specify compatible package version requirements in your root composer.json

For me, adding the following under require to mu project's root composer.json worked nicely:

drupal/csv_serialization": "2.0-beta1 as 1.4,

That said, using the latest version of CSV Serialization worked nicely. So, in my opinion, this issue should be merged ASAP, to avoid the necessity of the work-around above. Marking RTBC, as a result.

mehul.shah’s picture

mehul.shah commented

Facing the same issue when using the Entity Importer module, which has a dependency on the league/csv library having version above 9.0. On the other end I am using the Views data export which has dependency on the CSV serialization module, It has 2 versions available 8.x-1.4 & 8.x-2.0-beta1. The 8.x-2.0-beta1 uses league/csv 9.0 and above but Views data export requires CSV serialization 8.x-1.4. Can we update the module to use 8.x-2.0-beta1?

pobster’s picture

pobster commented

I hope this is merged soon ...

danharper’s picture

danharper commented

+1 this is causing issues with other modules that use the latest leageu_csv library like entity_import.

chris matthews’s picture

chris matthews commented

I pinged @jhedstrom to see if he can get the patch in #4 committed.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sébastien-fr’s picture

sébastien-fr
Primary language French
Location Nantes - France
commented

Add in composer.json : "drupal/csv_serialization": "2.0-beta1 as 1.4" works for me.