Drupal 9 readiness

Updating this to reflect this issue will cover all code needed for D9 readiness.

Fixed both warnings found by Upgrade status

2 warnings found.

web/modules/contrib/acquia_purge/src/Plugin/Purge/DiagnosticCheck/AcquiaCloudCheck.php:
─────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
─────────────────────────────────────────────────────────────────────
Fix later 63 Call to deprecated function system_get_info(). Deprecated in
drupal:8.8.0 and is removed from drupal:9.0.0. Use
\Drupal::service('extension.list.$type')->getExtensionInfo()
or
\Drupal::service('extension.list.$type')->getAllInstalledInfo() instead.

─────────────────────────────────────────────────────────────────────

web/modules/contrib/acquia_purge/acquia_purge.info.yml:
─────────────────────────────────────────────────────────────────────
STATUS LINE MESSAGE
─────────────────────────────────────────────────────────────────────
Check 0 Add core_version_requirement: ^8 || ^9 to
manually acquia_purge.info.yml to designate that the module is
compatible with Drupal 9. See https://www.drupal.org/node/3070687.

─────────────────────────────────────────────────────────────────────

@sushyl The patch looks fine. I reviewed and tested it and it works as expected.

hi @drupalfox and @sushyl

+++ b/src/Plugin/Purge/DiagnosticCheck/AcquiaCloudCheck.php
@@ -60,7 +60,7 @@ class AcquiaCloudCheck extends DiagnosticCheckBase implements DiagnosticCheckInt
+    $version = \Drupal::service('extension.list.module')->getExtensionInfo('acquia_purge');

Since we are using a service here, we should be using dependency injection, Hence setting this to needs work

Here is an updated patch,

Please review

Applied the patch in #13

Ran Drupal-check & Rector. Below are the results. Thus marking it RTBC.

drupal8/modules/custom git/8.9.x*  20s
❯ drupal-check -ad acquia_purge 
 23/23 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors                                                                                                         
                                                                                                                        

                                                                                                                                                                                                                                              
drupal8/modules/custom git/8.9.x*  6s
❯ ../../
                                                                                                                                                                                                                                              
drupal8 git/8.9.x*  
❯ vendor/bin/rector process modules/custom/acquia_purge --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

 69/69 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                   
                                                                                                                        

                                                                                                                                                                                                                                              

Patch #13 works for me too. It would be great if we can have it committed to dev so we're able to test the module on D9 projects.

The patch in #13 will fail for 1.1+ since the changes have been made already.

I think this issue can be marked as closed (outdated), since all the relevant changes are already committed in the latest version of codebase.