Move code from to new method

  • WebformElementBase::getDefaultProperties to protected WebformElementBase::defineDefaultProperties

Update WebformElementBase::getDefaultProperties

  • Call WebformElementBase::defineDfaultProperties
  • Add hook_webform_element_default_properties_alter()
  • Add caching

Deprecate and rename protected method

  • WebformElementBase::getDefaultMultipleProperties to WebformElementBase::defineDefaultMultipleProperties
  • WebformElementBase::getDefaultBaseProperties to WebformElementBase:defineDefaultBaseProperties
CommentFileSizeAuthor
#12 3107540-12.patch111.72 KBjrockowitz
#11 3107540-11.patch170.15 KBjrockowitz
#8 3107540-6.patch101.05 KBjrockowitz
#6 3107540-5.patch101.04 KBjrockowitz
#3 3107540-4.patch97.81 KBjrockowitz
#2 3107540-3.patch99.28 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new 3107540-3.patch99.28 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3107540-4.patch97.81 KB

  • 5419dd4 committed on 3107540-default-properties 
    Issue #3107540: Rename get default properties and related methods mark...
  • c3ce4a1 committed on 3107540-default-properties
    Issue #3107540 by jrockowitz: Rename get default properties and related...

  • d5d6a6e committed on 3107540-default-properties 
    Issue #3107540 by jrockowitz: Rename get default properties and related...
jrockowitz’s picture

jrockowitz commented
Issue summary: View changes
StatusFileSize
new 3107540-5.patch101.04 KB

  • f138891 committed on 3107540-default-properties 
    Issue #3107540 by jrockowitz: Rename get default properties and related...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3107540-6.patch101.05 KB
jrockowitz’s picture

jrockowitz commented
Title: Rename get default properties and related methods mark as deprecated. » Refactor and rename get default properties and related methods

  • 742e926 committed on 3107540-default-properties 
    Issue #3107540 by jrockowitz: Rename get default properties and related...
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3107540-11.patch170.15 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3107540-12.patch111.72 KB

Here is a cleaner patch.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz authored ee79e5a on 8.x-5.x 
    refactor/api (MAJOR): Issue #3107540 by jrockowitz: Refactor and rename...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • 82f106f committed on 8.x-5.x 
    Issue #3107540 by jrockowitz: Refactor and rename get default properties...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.