Tracker only tracks changes by the node owner

This seems like a good idea.

Are we able to use the revision author value instead of relying on the current user?

Also we should make the same change in the tracker_cron() logic.

Even though this is a bugfix, I think it's a minor-only change, since it's changing the behavior of the module. So, moving to 9.1.x-dev. Thanks!

Tested the changes for tracker_node_update as follows but not the cron code since I'm not sure how to test the cron code:

1) Enable Activity Tracker module

2) Create additional user account (username=hello)

3) Add Article content with author of hello

4) Check /user/[new user id]/activity and only relevant "hello" activity should show up

5) Add Article content with author of user 1

6) Check /user/1/activity and only relevant user 1 activity should show up

7) Update user 1's content by user 1

8) Update hello's content by user 1

9) Check /user/1/activity and only relevant user 1 activity should show up

10) Check /user/[new user id]/activity and only relevant "hello" activity should show up

While it works as expected, the table shows "Last updated" which is technically correct though maybe it would make sense to show "Last updated by me" since that might more relevant but it really depends on what the user is looking for.

Without patch:

With patch:

Fixing one of the screenshots.

Adding tag as I worked on this yesterday for the Bug Smash Initiative.

Also, if someone can provide notes/steps for testing the cron, that would be great.

Let's add some tests here.

Back to "Needs work" for tests.

Uploading test to evaluate scenarios mentioned above.

I have tested this patch. Patch is not applying correctly. Need to re-roll it.

Re-rolled patch. Please review.

- Fixing the issue in re-roll which was causing test-case failures.
In comment #12, _tracker_add($node->id(), $node->getRevisionUserId(), $node->getChangedTime()); snippet was in tracker_node_update hook.
- Remove deprecated functions from test cases.

Thanks for the update. I'm confused on this part:

+++ b/core/modules/tracker/tests/src/Functional/TrackerTest.php
@@ -474,4 +474,35 @@ public function assertHistoryMetadata($node_id, $node_timestamp, $node_last_comm
+    // Login with other user and update the node.
+    $updated_title = 'Test Article from ' . $this->otherUser->getAccountName();
+    $this->drupalLogin($this->otherUser);
+
+    $this->drupalGet('node/' . $node->id() . '/edit');
+    $edit['title[0][value]'] = 'Test Article from ' . $this->otherUser->getAccountName();
+    $this->submitForm($edit, 'Save');

Wouldn't it be better to be something like this?

+    // Login with other user and update the node.
+    $this->drupalLogin($this->otherUser);
+    $updated_title = 'Test Article from ' . $this->otherUser->getAccountName();
+
+    $this->drupalGet('node/' . $node->id() . '/edit');
+    $edit['title[0][value]'] = $updated_title;
+    $this->submitForm($edit, 'Save');

i.e. reuse $updated_title?

@Kristen Pol, thanks for the heads up!!
It was surely a miss. Fixed it.

Thanks for the update. The interdiff change looks good. Some thoughts :)

1) Next time, it would be good to have a test only patch added first, so we see it fails without the fix.

2) Don't we also need a test for the cron?

3) I'm not sure how to manually test the cron.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Tracker is deprecated for removal in Drupal 11, this issue can be moved to the contributed module once the Drupal 11 branch is open.

I am applying the patch in #20 to this contrib version of tracker, it works without issue.

I created a MR from the patch