Hi,

In the version 8, it still remains some functions in the linkchecker.module file that comes from the version 7 of Linkchecker:
- _linkchecker_cleanup_links()
- _linkchecker_check_markup()

I create a patch to remove this unused code.

CommentFileSizeAuthor
#2 3104574-remove-unused-code-2.patch6.01 KBtomefa

Comments

Tomefa created an issue. See original summary.

tomefa’s picture

tomefa commented
StatusFileSize
new 3104574-remove-unused-code-2.patch6.01 KB

Here is the patch

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

+1 for removing these unused functions.

IMO _linkchecker_isvalid_response_code can also move to a dedicated class/service but that can be handled in a separate issue.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Assigned: tomefa » Unassigned

  • C_Logemann committed 4196af8 on 8.x-1.x authored by Tomefa 
    Issue #3104574 by Tomefa: Remove unused code that comes from the drupal7...
c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented

I have checked this change and aleready commited it.

c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
c-logemann’s picture

c-logemann
he/him
Primary language German
Location Frankfurt/M, Germany
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.