1. Add the media as a reference field in the Basic Page content type.(Allow unlimited)
2. Add basic page content.
3. While adding a basic page in the media section click Add Media.

Select all media checkbox is missing media library popup.

Comments

naresh_bavaskar created an issue. See original summary.

naresh_bavaskar’s picture

Assigned: naresh_bavaskar » Unassigned
Status: Active » Needs review
StatusFileSize
new1009 bytes

Please find the attached patch

hardik_patel_12’s picture

Assigned: Unassigned » hardik_patel_12
hardik_patel_12’s picture

Assigned: hardik_patel_12 » Unassigned
Status: Needs review » Needs work
StatusFileSize
new396.19 KB

patch is working fine , but it has some coding standards error kindly resolve that.

hardik_patel_12’s picture

Status: Needs work » Needs review
StatusFileSize
new449 bytes
new1.22 KB

kindly review a new patch

Status: Needs review » Needs work

The last submitted patch, 5: 3104200-5.patch, failed testing. View results

hardik_patel_12’s picture

Status: Needs work » Needs review
StatusFileSize
new2.01 KB
new848 bytes

Kindly review a new patch

Status: Needs review » Needs work

The last submitted patch, 7: 3104200-7.patch, failed testing. View results

hardik_patel_12’s picture

StatusFileSize
new2.97 KB
new1019 bytes

Kindly review a new patch

hardik_patel_12’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 3104200-9.patch, failed testing. View results

swatichouhan012’s picture

Assigned: Unassigned » swatichouhan012
Issue tags: +VbContribution2020

We will work in #VbContribution2020.

swatichouhan012’s picture

Assigned: swatichouhan012 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.02 KB
new695 bytes

kindly review new patch.

Status: Needs review » Needs work

The last submitted patch, 13: 3104200-13.patch, failed testing. View results

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

kishor_kolekar’s picture

Status: Needs work » Needs review
StatusFileSize
new3 KB

I've re-rolled patch for 9.1

Status: Needs review » Needs work

The last submitted patch, 16: 3104200-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

phenaproxima’s picture

Status: Needs work » Closed (won't fix)
Issue tags: -media +Usability

I am not in favor of this idea, so I'm closing this issue. That being said, I'm totally open to reopening it for discussion with the UX team if enough people think that it would add real value.

Here's the thing: the media library specifically hides the "select all" checkbox because it doesn't seem useful when selecting media to use in a field or WYSIWYG editor. I can't imagine that it is common for people to want to select all available media items in either of those situations.

On top of that, it doesn't seem like it would be beneficial from a usability standpoint. The media library has very limited screen space to work with, which means it needs to be heavily optimized for usability. Everything in it needs to be as useful as possible to the task at hand. I think that a "select all" checkbox would be an additional visual element that would increase the "clutter" and cognitive load, but not be very useful to most people.

Therefore, this feature feels more suited to contrib.

phenaproxima’s picture

Title: Select All media option is missing while adding media in Grid view » [PP-1] Select All media option is missing while adding media in Grid view
Status: Closed (won't fix) » Postponed

Welp, I just discovered the existence of #3104006: Select All media option is missing while adding media in Table format, so rather than wontfix that too, I will simply postpone this one on that one, since it is much further along, but it needs usability and accessibility review.

phenaproxima’s picture

Category: Bug report » Feature request
Issue tags: +Media Initiative, +Triaged Media Initiative issue

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.