While working on #2007692: Changes in related entities don't lead to proper re-indexing, it occurred to me that the \Drupal\search_api\Plugin\search_api\datasource\EntityDatasourceInterface interface seems pretty useless. It neither seems to be used anywhere (except for implementing it, and for some reason checking that the entity:* datasources do actually implement it), nor do I know of any other module implementing it with a datasource plugin.

So, I’d probably just deprecate the whole thing?
Or, at the very least, the static method, which is particularly useless on an interface.

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs review

Simple patch plus change record.

drunken monkey’s picture

drunken monkey’s picture

Links should point to the CR, not the issue.

drunken monkey’s picture

Forgot to (explicitly) mention: Feedback on whether we should actually do this would be very much welcome.

drunken monkey’s picture

Status: Needs review » Fixed

Committed.

  • drunken monkey committed b624a4b on 8.x-1.x
    Issue #3102603 by drunken monkey: Deprecated EntityDatasourceInterface.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.