Add a trailing slash to the path form element in the redirect source widget to make it more clear that a URL redirect should not contain a leading slash.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3101563-7.patch | 815 bytes | jeroent |
Add a trailing slash to the path form element in the redirect source widget to make it more clear that a URL redirect should not contain a leading slash.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3101563-7.patch | 815 bytes | jeroent |
Comments
Comment #2
jeroentComment #3
jeroentBefore:
After:
Comment #4
jeroentComment #5
berdirThe problem is that this trailing / *is* there on a non-multilingual site, so this would result in two traiing slashes and we need to make sure to prevent that.
Comment #6
berdirThat said, the language suffix is actually confusing too, because it's the language field that defines the prefix, so maybe we should just cut that off?
Comment #7
jeroentYou're right, makes sense to cut off the language prefix.
Comment #8
jeroentComment #9
mizutaniDC commentedThis is a patch that supports multilingual sites and has exactly one trailing slash.
Comment #10
s3b0un3tThe patch of @mizutaniDC (comment # 9) works perfectly for a multilingual site with path prefix.
Comment #11
berdirI'm not sure about #9, #7 makes more sense to me, to never show the language prefix. Having the language prefix is misleading as you can then combine it with another language or language agnostic. Wondering if we should have a test for that.
Comment #12
anybodyRTBC for #7 - works perfectly for me and is language neutral at this page, which also makes more sense as the language selection is a setting at the bottom.
Comment #13
anybodyComment #14
berdirCommitted #7.