Closed (fixed)
Project:
Scheduler
Version:
8.x-1.x-dev
Component:
Testing
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2019 at 18:07 UTC
Updated:
1 Sep 2020 at 19:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jonathan1055 commentedThe failure is in tests/src/Functional/SchedulerRulesEventsTest.php, line 72 when trying to save a reaction rule.
The tests do not fail on drupal.org because here we use Rules alpha5 (the latest tagged release). Locally and on Travis testing, where the latest -dev version of Rules is used, we see this failure.
Comment #3
jonathan1055 commentedIn manual testing, when attempting to first save a new ReactionRule having selected the event "After updating existing content that is scheduled for publishing"
Comment #4
jonathan1055 commentedSolved by changinf
context:tocontext_definitions:in scheduler_rules_integration.rules.events.ymlComment #5
jonathan1055 commentedThis now works locally and on Travis tests, but will fail on drupal.org tests which use Rules Alpha5 not the latest -dev.
Comment #6
jonathan1055 commentedDid not expect that particular failure in #5.
Patch #6 changes the context keys in RulesActions and Conditions, but not in the .rules.events.yml file.
Comment #7
jonathan1055 commentedPatch #7 has the combined changes from #5 and #6.
Comment #8
jonathan1055 commentedNow add composer.json change to load Rules and Typed Data -dev versions.
Comment #9
jonathan1055 commentedTests pass with -dev Rules and Typed Data. So the changes cannot be committed until a new Rules and Typed Data tagged release is made, as we do not want to use -dev versions in composer.json.
See #3093191: Plan for Typed Data release 8.x-1.0-alpha4
Comment #11
jonathan1055 commentedRules now has release 8.x-3.0-alpha6 (released 20 July) so the changes in #7 can be made. Also the temporary patching in .travis.yml needs to be removed.
Comment #14
jonathan1055 commented