The current version just checks to see if the version number returned is higher than the integer 4.3. Once CKeditor sub-versions hit 2 digits, it's possible for this version check to fail incorrectly. (For example, 4.13 is numerically smaller than 4.3, even though it represents a higher version number.)

A patch is incoming that switches this to use PHP's version_compare function.

CommentFileSizeAuthor
#2 fix_version_check-3100988-2.patch498 byteskpaxman

Comments

kpaxman created an issue. See original summary.

kpaxman’s picture

kpaxman commented
Status: Active » Needs review
StatusFileSize
new fix_version_check-3100988-2.patch498 bytes

Patch attached.

robpowell’s picture

robpowell
he/him
Location Boston
commented

This looks good to me.

One note, it changes the comparison from '>' to '>='. I don't think that will be a problem but I can't find any documentation to confirm.

robpowell’s picture

robpowell
he/him
Location Boston
commented
Status: Needs review » Reviewed & tested by the community
kpaxman’s picture

kpaxman commented

You know, I noticed that after the fact. For what it's worth, the module page says "using CKeditor 4.3+" which I would tend to interpret as "4.3 or greater" as opposed to "greater than 4.3", which I chose to take as a sign to leave the change in place.

...but I can't confirm that 4.3 would actually work.

jenna.tollerson’s picture

jenna.tollerson
she/her
Primary language English
Location Atlanta, Georgia, USA
commented
Status: Reviewed & tested by the community » Fixed

It's a long time ago now, but I think I took that requirement directly from the CKEditor plugin page. My hunch is that y'all are correct and that "greater than or equal to" should have been the comparison all along. :)

Thank you so much for the patch @kpaxman, and for the review @robpowell!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.