------ --------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/site_settings_type_permissions/src/Tests/SiteSettingTypePermissionsUiTest.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\site_settings_type_permissions\Tests\SiteSettingTypePermissionsUiTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------
  Line   src/Controller/SiteSettingEntityAddController.php
 ------ ----------------------------------------------------------------------------------------------
  74     Call to deprecated method getLinkGenerator() of class Drupal\Core\Controller\ControllerBase:
         in drupal:8.0.0 and is removed from drupal:9.0.0. Inject the
 ------ ----------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------
  Line   src/Tests/SiteSettingsLoaderTest.php
 ------ -----------------------------------------------------------------------------------------------------------------
  12     Class Drupal\site_settings\Tests\SiteSettingsLoaderTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  25     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -----------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------
  Line   src/Tests/SiteSettingsUiTest.php
 ------ -------------------------------------------------------------------------------------------------------------
  12     Class Drupal\site_settings\Tests\SiteSettingsUiTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  25     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -------------------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#6 issue-3100624-6-depr-test-only.patch58.51 KBmr.york
#6 issue-3100624-6.patch57.56 KBmr.york
#4 issue-3100624-4-depr-test-only.patch57.31 KBmr.york
#4 issue-3100624-4.patch56.36 KBmr.york
#2 issue-3100624-2.patch57.02 KBmr.york

Comments

mr.york created an issue. See original summary.

mr.york’s picture

mr.york commented
Status: Active » Needs review
StatusFileSize
new issue-3100624-2.patch57.02 KB

Attached patch.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Needs work

Still needs a few minor adjustments.

mr.york’s picture

mr.york commented
Status: Needs work » Needs review
StatusFileSize
new issue-3100624-4.patch56.36 KB
new issue-3100624-4-depr-test-only.patch57.31 KB

Add little fix and deprecated test.

nagy.balint’s picture

nagy.balint commented
Status: Needs review » Needs work
mr.york’s picture

mr.york commented
Status: Needs work » Needs review
StatusFileSize
new issue-3100624-6.patch57.56 KB
new issue-3100624-6-depr-test-only.patch58.51 KB

Remove secret deprecation and code style fix.

nagy.balint’s picture

nagy.balint commented

Likely we have to remove that "match_limit" from the test config as described here https://www.drupal.org/project/ctools/issues/3100535
That way it remains compatible with 8.7 and wont fail on d9 (most likely)

nagy.balint’s picture

nagy.balint commented

So after further consideration, this "match_limit" would only break the tests on 8.7, the module itself would work fine, as it is only in the test module.
We have tested the module with this patch on 8.7 manually as well.

@scott_euser : Could we commit issue-3100624-6.patch ?

scott_euser’s picture

scott_euser commented

Thanks for all your work on this!

Shall we just apply a Drupal Core >= 8.8 to the composer.json and module info.yml files? I am struggling to understand from https://www.drupal.org/core/release-cycle-overview whether that is something allowed or whether we need to wait for 8.9 release.

Otherwise, all looks great; thanks for converting everything to dependency injection and all the work updating the tests.

nagy.balint’s picture

nagy.balint commented

Hi,

Yes its allowed, however 8.7 is still supported til June, and as only the test would break, we dont necessarily need to remove compatibility.

On drupal.org the tests run on 8.9 dev anyways, and we could write in the release notes that we kept compatibility with 8.7 but the tests only work from 8.8+

scott_euser’s picture

scott_euser commented

Okay sounds good, I'll commit and add to release notes. Thanks for the advice! I'll take care of this after the holidays.

  • scott_euser committed 82451c2 on 8.x-1.x authored by mr.york 
    Issue #3100624 by mr.york, nagy.balint: Drupal 9 Deprecated code report
scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks!

nagy.balint’s picture

nagy.balint commented

Thanks!

Can you create a new release?

scott_euser’s picture

scott_euser commented

Sure no problem - release created

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.