After adding support for external stylesheets the next step is to add support for Drupal root paths, in the same way that Library definitions can have a Drupal root url for CSS/JS assets.

Stylesheets that aren't external and use a '/' as the first character can be safely assumed to be Drupal root relative (this what LibraryDiscoveryParser does).

So the supported set of stylesheets paths would look like this:

ckeditor_stylesheets
  - //www.external.com/stylesheet.css
  - /libraries/your-library/stylesheet.css
  - css/stylesheet.css

The use case for this is to include CSS assets from outside the theme directory (i.e. the libraries directory).

CommentFileSizeAuthor
#9 3099662-9.patch3.05 KBjibran
#9 interdiff-035daa.txt553 bytesjibran
#5 interdiff-3099662-ckeditor-root-1-5.txt826 bytesdpi
#5 3099662-ckeditor-root-5.patch3.08 KBdpi
ckeditor_stylesheets_drupal_root_url.patch3.06 KBjptaranto

Comments

jptaranto created an issue. See original summary.

jptaranto’s picture

jptaranto
Primary language English
Location Sydney
commented

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

dpi’s picture

dpi
Location Perth, Australia
commented
Version: 8.9.x-dev » 9.1.x-dev
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Needs review
StatusFileSize
new 3099662-ckeditor-root-5.patch3.08 KB
new interdiff-3099662-ckeditor-root-1-5.txt826 bytes

Fixing D9 compat.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs change record

Can we get a change notice here?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

The code changes look good and comes with test also created change record https://www.drupal.org/node/3161831 so RTBC.

nod_’s picture

nod_
Primary language French
Location Lille
commented 
+++ b/core/modules/ckeditor/ckeditor.module
@@ -89,9 +89,15 @@ function _ckeditor_theme_css($theme = NULL) {
+        elseif ($url[0] === '/' && $url[1] !== '/') {

We just need $url[0] === '/' here, the double slash is checked by the condition above.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff-035daa.txt553 bytes
new 3099662-9.patch3.05 KB

Nice catch! addressed #8.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 610682e and pushed to 9.1.x. Thanks!

  • alexpott committed 610682e on 9.1.x 
    Issue #3099662 by jibran, dpi, jptaranto, larowlan, nod_: Allow...
saschaeggi’s picture

saschaeggi
he/him
commented

Awesome news, I've created a follow-up to bring the same functionality to quickedit_stylesheets => #3162637: Allow quickedit_stylesheets to refer to a Drupal root URL

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2682723: Allow ckeditor_stylesheets to refer to external URL, for e.g. webfonts, +#3162637: Allow quickedit_stylesheets to refer to a Drupal root URL

I'm sorry that I didn't see this until now — until after commit. 🙈

This makes total sense, thanks for doing this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.