Under some circumstances there are errors thrown by the consecutive dates widget (see screenshot)

CommentFileSizeAuthor
#3 recurring_events-consecutive_dates_pass_by_reference-3099593-3.patch1.33 KBowenbush
#3 interdiff-2-3.txt749 bytesowenbush
#2 recurring_events-consecutive_dates_pass_by_reference-3099593-2.patch1.3 KBowenbush
Screen Shot 2019-12-09 at 3.07.15 am.png555.81 KBowenbush

Comments

owenbush created an issue. See original summary.

owenbush’s picture

owenbush commented
Status: Active » Needs review
StatusFileSize
new recurring_events-consecutive_dates_pass_by_reference-3099593-2.patch1.3 KB

Attached is a patch to address this issue.

owenbush’s picture

owenbush commented
StatusFileSize
new interdiff-2-3.txt749 bytes
new recurring_events-consecutive_dates_pass_by_reference-3099593-3.patch1.33 KB

This actually resolved part of the issue but just moved it elsewhere, attached is a new patch and an interdiff

the_glitch’s picture

the_glitch commented

tested patch #3 and seems to have resolved the issue. Thanks Owen.

owenbush’s picture

owenbush commented
Status: Needs review » Reviewed & tested by the community

Great, thanks. Crediting the_glitch for the find and test.

  • owenbush committed 8265ef9 on 8.x-1.x 
    Issue #3099593 by owenbush, the_glitch: Consecutive Dates - Only...
owenbush’s picture

owenbush commented
Status: Reviewed & tested by the community » Fixed

This has been merged. Marking as fixed.

the_glitch’s picture

the_glitch commented

Thanks for the credit Owen

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.