Problem/Motivation

In #3092452: Critical SimpleSAMLphp security release 2019-11-06 SimpleSAMLphp is updated to the version 1.17.7 and the DvG patch for generating the SP metadata was rerolled against that version. The new version of the patch introduced an error for SAML configurations that don't use or have incorrect configured indexed AssertionConsumerServices. Also some parts of the original fix don't work correctly anymore.

Proposed resolution

Update SimpleSAMLphp library to the latest version (1.18.2) and reroll the patch to fix the original problem.

CommentFileSizeAuthor
#3 dvg-simplesamlphp_1_18_2_metadata_attributes-3099018-3.patch70 KBpaulvandenburg
#3 interdiff-2-3.txt134.2 KBpaulvandenburg
#2 dvg-simplesamlphp_1_18_2_metadata_attributes-3099018-2.patch70.07 KBtvoesenek

Comments

TVoesenek created an issue. See original summary.

tvoesenek’s picture

tvoesenek commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new dvg-simplesamlphp_1_18_2_metadata_attributes-3099018-2.patch70.07 KB

This patch contains the following:

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new interdiff-2-3.txt134.2 KB
new dvg-simplesamlphp_1_18_2_metadata_attributes-3099018-3.patch70 KB

Looks good, solves the problems and everything still seems to work nicely.

However 1 small nitpick, I've removed the issue number from those 2 local patches. Those patches aren't forever tied to this issue so that might become confusing in the future when multiple issues might change stuff there.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

paulvandenburg’s picture

paulvandenburg commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.