Currently, the simplesamlphp library contains a full config and metadata directory, which unexpecting users might add to their version control system. The config and metadata should be empty, given the fact that both have template dirs available in the upstream package and the files are 100% equal in both directories.

This could also be done by using a .gitignore, but that doesn't add to visibility and might be unexpected behavior for less experienced users.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MrHaroldA created an issue. See original summary.

MrHaroldA’s picture

Status: Active » Needs review
FileSize
52.25 KB

  • MrHaroldA committed 44af4f0 on 7.x-1.x
    Issue #2613356 by MrHaroldA: Remove default metadata + config from...
ralphvdhoudt’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ralphvdhoudt’s picture

Added patch against simplesamlphp-1.14.11

askibinski’s picture

Here is an updated patch for 1.5.4.

TVoesenek’s picture

FileSize
64.68 KB

Re-rolled the patch for simplesamlphp 1.16.1

TVoesenek’s picture

Status: Closed (fixed) » Needs review
TVoesenek’s picture

FileSize
63.43 KB

Patch from #8 removed the files from the config- and metadata-templates directories, instead of the config and metadata directory. This patch should be right.

ruudvanoijen’s picture

Patch applies and works.

paulvandenburg’s picture

Status: Needs review » Fixed

The #10 patch was already added in #3000768: Update SimpleSAMLPHP to 1.16.1 so I'm marking this one fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

paulvandenburg’s picture

This patch is equal to #10 but applies to simplesamlphp version 1.16.3

paulvandenburg’s picture

Patch that should work with simplesamlphp 1.17.6 (and 1.17.7).