[D8] Label Length limit

Thank you for applying! Please see Applying for permission to opt into security advisory coverage for the information that needs to be provided in these applications.

I am closing this application due to lack of replies.
The same information has been requested on #3042081: [D8] Change Label Length limit, created for the same project.

Hello yuseferi,

Checked and fixed issues using pareview.sh

Review of the 8.x-1.x branch (commit 385dcbe):

• README.md or README.txt is missing, see the guidelines for in-project documentation.
• Remove all .idea files from your repository.
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...endor/drupal/pareviewsh/pareview_temp/label_length_limit.routing.yml
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   8 | WARNING | The administration page callback should probably use
     |         | "administer site configuration" - which implies the user
     |         | can change something - rather than "access administration
     |         | pages" which is about viewing but not changing
     |         | configurations.
  --------------------------------------------------------------------------
  
  Time: 237ms; Memory: 4Mb
  

• No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/label_length_limit.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  29 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
  97 | ERROR | [ ] Missing parameter type
 103 | ERROR | [ ] Missing parameter type
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/label_length_limit.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/label_length_limit.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/LabelLengthLimitForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 46 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------

Time: 542ms; Memory: 4Mb

Looks good to me.

Thanks for your contribution, Yusef!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.