Use full path with different domain

After applying attached patch, you will be able to redirect to different domain based on roles.

Steps to test:

1. For External URL:

• Create two roles. Say role_1, role_2
• Then add login destination rules based on roles.
• Make sure it's redirecting correctly.

2. Repeat same steps for internal URL.

Hi,

I have tested this patch it is working for me.

Thanks for the patch!

I have a question:
- in the 2nd patch hunk in the function login_destination_perform_redirect() , we have:
---
179 if ($destination) {
180 // Check if it's a external URL.
181 if (UrlHelper::isExternal($destination->destination_path)) {
182 $response = new TrustedRedirectResponse($destination->destination_path);
183 $response->send();
184 }
185 $service->prepareDestination($destination);
---

... so the patch adds $response->send().

Then if the link is not external, we have $service->prepareDestination($destination);

My question, is it the right thing to call $response->send(); within login_destination_perform_redirect()
or is it better to call it from within prepareDestination() located in login_destination/src/LoginDestinationManager.php?
The added snippet of code in the hunk seems right , I wonder where is the right place to put that snipper?
I mean this snippet above - from line 181 to 184.

In the end #4 looks good to me. Committing.