Problem

See problem definition in #3092272: [Meta] Moving away from features.

Solution

  • Remove the module.features.yml file
  • Move the default editable config from hook_install() into a module's config/install/*.yml file.
  • If hook_install alters configuration from other modules, consider whether we should include the config file in the profile's config/install folder to overwrite it instead
  • Remove any _module_set_defaults function

Steps to reproduce

  • Enable all changed modules
  • See that none of them install configuration provided by other modules
  • Change configuration for each module
  • Revert features

Expected result (after fix)

The changed configuration keeps its changes.

Actual result

The changed configuration is reverted to default values.

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

kingdutch’s picture

Issue summary: View changes
Status: Active » Needs review

Update reproduction steps. PR here: https://github.com/goalgorilla/open_social/pull/1614

kingdutch’s picture

ronaldtebrake’s picture

Status: Needs review » Fixed

  • Kingdutch committed 7680799 on 8.x-8.x
    Issue #3096571 by Kingdutch: Remove features from social_event_managers...
  • Kingdutch committed 9e5fc93 on 8.x-8.x
    Issue #3096571 by Kingdutch: Remove features from social_event_an_enroll...
  • Kingdutch committed da5b7fe on 8.x-8.x
    Issue #3096571 by Kingdutch: Add configuration schema to...
  • Kingdutch committed f736a79 on 8.x-8.x
    Issue #3096571 by Kingdutch: Remove features from social_event_type...
  • ronaldtebrake authored f309a5d on 8.x-8.x
    Merge pull request #1614 from goalgorilla/feature/3096571-remove-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.