Separate UI strings touching each other

#2 patch looks good to me. +1 to RTBC.
Here are the screenshots attached. Changing the status to RTBC.
The automated script will pass hopefully.

Looks better.

@Balu Ertl,

+++ b/core/modules/tracker/js/tracker-history.es6.js
@@ -19,7 +19,7 @@
if (timestamp > lastViewTimestamp) {
const message =
lastViewTimestamp === 0 ? newNodeString : updatedNodeString;
- $(placeholder).append(`${message}`);
+ $(placeholder).append(` ${message}`);
}
});
}

changes is not required.

Kindly follow a new patch.

@Balu Ertl you're correct that the .es6.js file is the one where changes should be made and then transpiled to the .js using the dev tools.

However, as far as I can see you're rtbc'ing your own patch which is not how this works. The patch should be reviewed by someone other than the patch author and they should set it to rtbc.

One of the things missing from this issue is an analysis of how this change might affect existing sites. That said it does appear that in Drupal 7 days theme_mark would add this space and here we're removed it for no obvious reason.

Also it is very helpful if the most recent patch on the issue is the correct patch.

Here is the new patch with interdiff and screenshot please review.

I've re-rolled patch for 9.1

+++ b/core/modules/tracker/js/tracker-history.es6.js
@@ -19,7 +19,7 @@
-        $(placeholder).append(`<span class="marker">${message}</span>`);
+        $(placeholder).append('&nbsp;<span class="marker">${message}</span>');

Elsewhere in core we're not encoding a space as   - I'm not sure we need to. See Drupal.theme.quickeditImageDropzone for an example where we are using a space instead.

Patch 18 works for me; any chance it can be merged?

Spacing fixed with CSS. No need of &nsbp;
Adding after patch screenshot for reference. Please review.

The above patch works fine.
Before patch

After patch

Do we need to fix this through CSS?
We can simply fix it by adding a normal space before "<span>", like the following code

Drupal.theme.quickeditImageDropzone = function (settings) {
    return "<div class=\"quickedit-image-dropzone ".concat(settings.state, "\">") + '  <i class="quickedit-image-icon"></i>' + "  <span class=\"quickedit-image-text\">".concat(settings.text, "</span>") + '</div>';
  };

This extension is deprecated and scheduled for removal in Drupal 11.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

It will be moved to the contributed extension once the Drupal 11 branch is open.

MR needs rework for contrib module now

Re-roll of patch of #18 for 10.2.6 attached.

Created MR against contrib module