------ ---------------------------------------------- 
  Line   includes/fivestar.theme.inc                   
 ------ ---------------------------------------------- 
  93     Call to deprecated function drupal_render().  
 ------ ----------------------------------------------
CommentFileSizeAuthor
#12 3093612-11-deprecations.patch1.29 KBtr
#6 updated-3093612-6.patch1.42 KBkarishmaamin
#2 deprecated-3093612-2.patch642 bytessergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3093612-2.patch642 bytes

Here's the patch, please review.

init90’s picture

init90
Location Ukraine
commented
Title: Remove deprecated function drupal_render » Remove deprecated code
Status: Needs review » Needs work

Hi @sergiu-stici, thanks for your work. I think we should extend the scope of the issue.

Let's fix all drupal-check warnings:

 ------ --------------------------------------------------------------------- 
  Line   fivestar.module                                                      
 ------ --------------------------------------------------------------------- 
  225    Call to deprecated function file_scan_directory():                   
         in drupal:8.8.0 and is removed from drupal:9.0.0.                    
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.  
 ------ --------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   includes/fivestar.migrate.inc                                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
         Class MigrateFivestarFieldHandler was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------- 
  Line   includes/fivestar.theme.inc                                
 ------ ----------------------------------------------------------- 
  93     Call to deprecated function drupal_render():               
         in drupal:8.0.0 and is removed from drupal:9.0.0. Use the  
 ------ -----------------------------------------------------------
Vova Poroniuk’s picture

Vova Poroniuk commented
Title: Remove deprecated code » Remove deprecated Drupal 7 code
init90’s picture

init90
Location Ukraine
commented
Title: Remove deprecated Drupal 7 code » Remove Drupal 8 deprecated code
karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new updated-3093612-6.patch1.42 KB

please review the code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Remove Drupal 8 deprecated code » Remove deprecated code
tr’s picture

tr commented
Parent issue: » #2865381: [meta] Port to Drupal 8

Status: Needs review » Needs work

The last submitted patch, 6: updated-3093612-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tr’s picture

tr commented
Status: Needs work » Needs review

Patch #6 still applies.

tr’s picture

tr commented

@karishmaamin Your replacement for file_scan_directory() was just wrong. That code would never run - you can't call a method on an interface - interfaces don't have implementations, you need to use an actual class. Also, the syntax was for a static call when scanDirectory() is not a static function.

Here's a new patch to fix that.

tr’s picture

tr commented
StatusFileSize
new 3093612-11-deprecations.patch1.29 KB

Status: Needs review » Needs work

The last submitted patch, 12: 3093612-11-deprecations.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tr’s picture

tr commented
Status: Needs work » Needs review

  • TR committed 6ae7105 on 8.x-1.x 
    Issue #3093612 by TR, Sergiu Stici: Remove deprecated code
tr’s picture

tr commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.