Problem

See problem definition in #3092272: [Meta] Moving away from features. The fact that this configuration is in a feature means that site managers can't change the name of the taxonomies.

Solution

  • Remove the social_topic.features.yml file
  • Move the default editable config from hook_install() into a config/install/*.yml file.
  • Remove any _module_set_defaults function

Steps to reproduce

  • Enable the module
  • Change the name of the topic types vocabulary
  • Revert features

Expected result

The name of the vocabulary remains changed.

Actual result

The name of the vocabulary is reverted to its initial state.

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Needs review

PR here: https://github.com/goalgorilla/open_social/pull/1590

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Fixed

  • Kingdutch committed 9bc0b47 on 8.x-8.x 
    Issue #3092481 by Kingdutch: Remove features from Social Topic module...
  • ronaldtebrake authored 3b3fd07 on 8.x-8.x
    Merge pull request #1590 from goalgorilla/feature/TB-3133-remove-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.