Problem

See problem definition in #3092272: [Meta] Moving away from features. The fact that this configuration is in a feature means that site managers can't change the name of the taxonomies.

Solution

  • Remove the social_profile.features.yml file
  • Move the default editable config from social_profile_install() into a config/install/*.yml file.
  • Remove the _social_profile_set_defaults function

Steps to reproduce

  • Enable the Social Profile module
  • Change the name of the interests, profile tag, and expertise vocabulary
  • Revert features

Expected result

The name of the vocabularies remain changed.

Actual result

The name of the vocabularies are reverted to their initial state.

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Needs review

PR here: https://github.com/goalgorilla/open_social/pull/1589

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Fixed

  • Kingdutch committed 8cc55de on 8.x-8.x 
    Issue #3092460 by Kingdutch: Remove features from Social Profile module...
  • ronaldtebrake authored 76e42d6 on 8.x-8.x
    Merge pull request #1589 from goalgorilla/feature/TB-3133-remove-...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.