Description field is not rendered in node display.

See attached image.

CommentFileSizeAuthor
#5 3092215-description_is_not_rendered_in_field_formatter-5.patch2.94 KBtim-diels
#4 3092215-description_is_not_rendered_in_field_formatter-4.patch2.95 KBtim-diels
Screenshot 2019-11-04 at 14.22.07.png1.33 MBtamerzg
Screenshot 2019-11-04 at 14.21.42.png48.17 KBtamerzg

Issue fork cloudflare_stream-3092215

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tamerzg created an issue. See original summary.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

Let's develop this for 8.x-2.x & backport this to the 8.x-1.x version.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: Unassigned » tim-diels
Issue summary: View changes

Let's fix this for the 2.x version and backport for 1.x

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 3092215-description_is_not_rendered_in_field_formatter-4.patch2.95 KB

Added the description as a value to the template so it can be styled differently when needed.
Fixed also that the description was not saved on first save.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new 3092215-description_is_not_rendered_in_field_formatter-5.patch2.94 KB

Coding standards issue fixed.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Assigned: tim-diels » Unassigned
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Quickfix Need Reroll

I like what I'm seeing here!
However, we'll need a reroll since this patch can not be applied correctly.

  • pjbaert committed c273202 on 8.x-1.x authored by tim-diels 
    Issue #3236261 by tim-diels: Backport #3092215 Description is not...

tim-diels opened merge request !12

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll, -Quickfix Need Reroll

Created a merge request for easier follow up.

  • pjbaert committed 339163e on 8.x-2.x authored by tim-diels 
    Issue #3092215 by tim-diels, pjbaert, tamerzg: Issue #3092215 by tim-...
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs review » Fixed

I'm happy to have this feature in this module! 🥳
Thanks for your work!
Pushed to 2.x branch & backported to the 1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.