Hello,

We messed our config for some reason and then paths_per_scan had a value of null.
This created an infinite loop here because offset was never incremented.

I think an additional check could be added in order to avoid this.

CommentFileSizeAuthor
#5 3091445-5.patch603 bytesseanb

Comments

prudloff created an issue. See original summary.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Issue tags: -DrupalCon Amsterdam 2019 +Amsterdam2019

retagging

yepa’s picture

yepa
he/him
Primary language French
Location Geneva
commented

Working on it at DrupalCon Amsterdam 2019.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Thanks! Looking forward to your suggested fix :)

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
StatusFileSize
new 3091445-5.patch603 bytes

Turns out I forgot to git add the module config too after enabling the module (it did export the core.extension.yml). My colleagues were getting the error in #3091036: Fatal error occurred after that. Turns out they were missing the config as described here.

I think the attached patch would help prevent errors for people in similar situations.

  • Gábor Hojtsy committed 2f3550a on 8.x-1.x 
    Issue #3091445 by seanB, prudloff, yepa: Avoid infinite loop when...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Infinite loop when paths_per_scan is null » Avoid infinite loop when paths_per_scan is null
Status: Active » Fixed

Superb, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.