I have scanned the Rabbit hole module for deprecation warnings to get it ready for drupal 9. There were two warnings found, which I have attached as a screenshot.
In the Issue #3042689: Drupal 9 Deprecated Code Report, the second Warning about the PluginTestBase class was already discussed.

CommentFileSizeAuthor
#4 3091139-3.patch2.78 KBjonas139
#2 drupal-9-compability-3091139-2.patch342 bytesmalte.koelle
Screenshot 2019-10-30 at 13.58.54.png152.18 KBmalte.koelle

Comments

malte.koelle created an issue. See original summary.

malte.koelle’s picture

malte.koelle commented
Status: Active » Needs review
StatusFileSize
new drupal-9-compability-3091139-2.patch342 bytes

I have added the core version requirements in the info.yml file.

rocketeerbkw’s picture

rocketeerbkw commented
Status: Needs review » Needs work

There was another patch in #3114676: Drupal 9 compatibility I marked as duplicate that's different, so I'm gonna assume this needs work.

jonas139’s picture

jonas139 commented
Status: Needs work » Needs review
StatusFileSize
new 3091139-3.patch2.78 KB

I've uploaded my patch from issue #3114676: Drupal 9 compatibility here so it can be reviewed.
I've just added the core requirements to all submodules, suggested by @andrewmacpherson in issue #3039164: Convert automated tests based on Simpletest to PHPUnit.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

upchuk’s picture

upchuk commented

Is there any traction here?

walangitan’s picture

walangitan commented

comment removed, resolved in https://www.drupal.org/project/rabbit_hole/issues/3039164.

james.williams’s picture

james.williams
Location Coventry, UK
commented

Both this and #3039164: Convert automated tests based on Simpletest to PHPUnit are RTBC so please could a D9-compatible release be made? If there's a plan to include other work, it would be good to know where contribution efforts can go - I'd gladly help!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Agreed with @james.wiliams. This is important because this module is widely used. Thank you @maintainers :)

dylan donkersgoed’s picture

dylan donkersgoed commented

Sorry, meant to check these and merge them in this weekend but forgot about it. I'll take a look at it later this evening and if all is good I'll merge it in and probably tag a release.

dylan donkersgoed’s picture

dylan donkersgoed commented
Status: Reviewed & tested by the community » Fixed

I've merged this in.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you very much @Dylan!! :)

james.williams’s picture

james.williams
Location Coventry, UK
commented

Thank you!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.