Create a drupal 9 port, drupal 9 report

@tomvanetten Thank you for a contribution on Rate.

Here are additional issues for this:

#3074633: Replace deprecated entity_get_display()
#3073450: Replace deprecated drupal_set_message() with \Drupal::messenger()

Hi @Krzysztof Domański & @tomvanetten

I did a re-roll, because patch #6, have some issues with src/RateBotDetector.php becuase the branch 8.x-1.x already have those changes.

After more those change I ran drupal-check again and got this results.

 35/35 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------------------
  Line   src/Plugin/VoteResultFunction/CountUp.php
 ------ --------------------------------------------------------------------------------------
         Class Drupal\votingapi\VoteResultFunctionBase not found and could not be autoloaded.
 ------ --------------------------------------------------------------------------------------

But after downloading the Votinapi module, the errors were solved.

Please review and let me know if we are good for Drupal9

1. Let's add a separate problem for Drush deprecation. Also we can bump the minimum required version to 9.
https://docs.drush.org/en/latest/install/#drupal-compatibility

composer.json

+    "extra": {
+        "drush": {
+            "services": {
+                "drush.services.yml": "^9 || ^10"
+            }
+        }
+    }

2. Should be method_exists instead offunction_exists. Do we need a condition here when we bump the minimal version of Drush?

-  if (function_exists('writeln')) {
+  if (method_exists($this->output(), 'writeln')) {

1) Drupal\Tests\rate\Functional\NodeFivestarWidgetTest::testVoting
Exception: Warning: time() expects exactly 0 parameters, 2 given
Drupal\Core\Field\BaseFieldDefinition->getDefaultValue()() (Line: 469)

This is a problem in Voiting API module on PHP 7.3. It has been fixed already but only in the dev version.
#3048085: time() is used as a callback, and I'm assuming it's php7.3 that doesn't like time having parameters.

One more deprecated code Render callbacks must be a closure or implement TrustedCallbackInterface or RenderElementInterface.

  3x: Render #lazy_builder callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was Drupal\rate\RateEntityVoteWidget::buildRateVotingWidget. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725
    3x in ViewsFilterTest::testFilterMin from Drupal\Tests\rate\Functional\ViewsFilterTest.php

See https://git.drupalcode.org/project/rate/-/blob/8.x-1.x/src/Plugin/views/...

public function render(ResultRow $values) {
  $entity = $this->getEntity($values);
  $widget = [];

  if ($entity) {
    $widget = [
      '#lazy_builder' => ['rate.entity.vote_widget:buildRateVotingWidget',
        [
          $entity->id(),
          $entity->getEntityType()->id(),
          $entity->bundle(),
          $this->options['widget_type'],
        ],
      ],
      '#create_placeholder' => TRUE,
    ];
  }

  return $widget;
}

For #lazy_builder callbacks must be methods of a class that implements TrustedCallbackInterface we need to upload this patch as well

Needs a re-roll.

Hean a re-roll patch.

This module now has a Drupal 9 release, so I guess we can close this issue?

There is one more deprecated code.
Render callbacks must be a closure or implement TrustedCallbackInterface or RenderCallbackInterface

Yes, I think this issue can be closed. Code style issues will be fixed in another issues