Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
other
Priority:
Major
Category:
Plan
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Oct 2019 at 11:19 UTC
Updated:
25 Feb 2020 at 02:24 UTC
Jump to comment: Most recent
Comments
Comment #2
plachAdded tracking spreadsheet
Comment #3
plachPromoting to major
Comment #5
plachCrediting kim.pepper.
Comment #6
plach@kim.pepper wrote a nice blog post documenting the update process at https://www.previousnext.com.au/blog/updating-drupal-880-beta-composer.
Comment #7
berdirI've successfully updated both our install profiles and did run our behat and kernel tests against 8.8.0-beta1. That includes an automated upgrade path test on one install profile with a dump that is currently ~8.6-based, with a multilingual site and tons of contrib modules.
Results are looking good, beside the known pathauto issues that are fixed in the available 8.x-1.6-beta1 which is also documented in the blog post above, I only had to fix some minor update path things in webform, but they are only for the edge case of updating a rather old webform version directly to 8.8. That's also already committed.
Beside that, I only found a single regression in core which is already actively discussed and I believe can be fixed, will work on that: #2673980: RSS view with fields give wrong URL from path field.
Comment #8
plachThanks @Berdir, this sounds promising!
Comment #9
sokru commentedTested with custom installation profile, multilingual + 40 contrib modules.
No issues when using the correct pattern:
1) Update pathauto & drush cr
2) Update core.
When updating pathauto + core in simultaneously, got stuck with
system_update_8804. I think it should be documented how to proceed in that case, because I'm sure someone from 300k D8 sites will update without following the correct procedure.Comment #10
plach@sokru:
Thanks for reporting! Could you please open an issue with the details of the error you got? We can use that to track changes to the documentation or maybe even to improve
system_update_8804()to be more defensive.Comment #11
pameeela commentedUpdated one site successfully, with no errors. Not a huge site but 50-odd contrib modules and about 10 custom modules.
Got a warning because I had an incompatible version of Claro installed but once that was resolved the update was smooth.
Comment #12
rosk0Not sure how to report this but I found that Issue #3039026: Deprecate file_directory_temp() and move to FileSystem service is not mentioned in 8.8.0-alpha1 not in 8.8.0-beta1 release notes but it's quite significant change which requires developers attention. So while project (internal ref: MvwPG+Bjf4f9z14o) update was successful functionality was affected by a bit broken configuration. Should I still create a sub-issue for this? The obvious and most effective way of "fixing" it is actually update release notes for both (8.8.0-alpha1 & 8.8.0-beta1) releases to mention #3039026: Deprecate file_directory_temp() and move to FileSystem service and corresponding change record https://www.drupal.org/node/3039255 .
Comment #13
larowlanI updated two large sites, with a lot of contrib modules. No major issues - just some composer dancing and a patch to menu_item_extras as updating it broke Drush.
Comment #14
larowlan@RoSk0 agree, that does belong in the release notes - I'll add the tag
Comment #15
jibranI updated a large client site to Drupal 8.8.0 beta, other than pathauto #3093401: Compatibility with Drupal 8.8.0-beta1, subpathauto issue #3093377: Fix the failing HEAD and rerolling some core patches everything worked fine without a glitch.
Comment #16
plachThanks @jibran! Could you please confirm that the "subpathauto" issue is fixed with 8.8.x HEAD?
Comment #17
larowlanCurrently stuck on #3095390: Drupal Core 8.8-beta1 update fails with Group 8.x-1.0-rc4 for one of my sites.
GroupViewsDatain group module sub-classesEntityViewsDatawhich usesDeprecatedServicePropertyTraitto provide BC support for $this->entityManager.However it looks like route-rebuilding happens in a terminate event, and by that time the container doesn't have the service? So fails with
When it calls
$this->entityManager->getDefinitions()Comment #18
larowlanActually the issue there is that GroupViewsData defines an entityManager property so the magic __get doesn't fire
Comment #19
rosk0Found and issue with updating one of client projects (int ref GPR4hICg7eWZSLT3) :
Drupal\Component\Plugin\Exception\MissingValueContextException: Required contexts without a value: view_mode in Drupal\Core\Plugin\Context\ContextHandler->applyContextMapping() (line 155 of core/lib/Drupal/Core/Plugin/Context/ContextHandler.php).Not sure if it's coming from, panels or core, so not raising an issue for it yet.
Any tips welcome.
Comment #20
jibranRE#16:
Yes, the patch is working with 8.8 rc release.Edit: Yes, subpathauto issue is fixed in 8.8 RC.
Comment #22
plachComment #23
edva3000 commentedgood morning
I get the same RoSk0 error someone knows how I can fix it. Thanks for the help
Drupal\Component\Plugin\Exception\MissingValueContextException: Required contexts without a value: view_mode in Drupal\Core\Plugin\Context\ContextHandler->applyContextMapping() (line 155 of core/lib/Drupal/Core/Plugin/Context/ContextHandler.php).
Drupal\panels\Plugin\DisplayBuilder\StandardDisplayBuilder->buildRegions(Array, Array) (Line: 176)
Drupal\panels\Plugin\DisplayBuilder\StandardDisplayBuilder->build(Object) (Line: 190)
Drupal\panels_ipe\Plugin\DisplayBuilder\InPlaceEditorDisplayBuilder->build(Object) (Line: 329)
Drupal\panels\Plugin\DisplayVariant\PanelsDisplayVariant->build() (Line: 396)
Drupal\panelizer\PanelizerEntityViewBuilder->buildPanelized(Object, Object, 'full', NULL) (Line: 356)
Drupal\panelizer\PanelizerEntityViewBuilder->buildMultiplePanelized(Array, Array, 'full', NULL) (Line: 274)
Drupal\panelizer\PanelizerEntityViewBuilder->view(Object, 'full') (Line: 105)
Drupal\Core\Entity\Controller\EntityViewController->view(Object, 'full', NULL) (Line: 71)
Drupal\node\Controller\NodeViewController->view(Object, 'full', NULL)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 694)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Comment #24
cilefen commented@edva3000 Please open a new issue and link it here.