Isolate test dependency on easyrdf/easyrdf to a single trait

First step is to isolate calls to EasyRdf into a trait then we can chop from a single spot.

Here's a POC and a crack at converting CommentAttributesTest

Still to go:

• EntityReferenceFieldAttributesTest.php (2 usages found)
• FileFieldAttributesTest.php (1 usage found)
• ImageFieldAttributesTest.php (2 usages found)
• NodeAttributesTest.php (5 usages found)
• StandardProfileTest.php (17 usages found)
• TaxonomyAttributesTest.php (3 usages found)
• UserAttributesTest.php (4 usages found)
• FieldRdfaTestBase.php (1 usage found)

@amjad both, which you did 👍

+++ b/core/modules/rdf/tests/src/Functional/NodeAttributesTest.php
@@ -19,9 +22,37 @@ class NodeAttributesTest extends NodeTestBase {
+  /**
+   * URI of the front page of the Drupal site.
+   *
+   * @var string
+   */
+  protected $baseUri;
+
+  /**
+   * Node for testing.
+   *
+   * @var \Drupal\node\Entity\Node
+   */
+  protected $node;
+
+  /**
+   * URI of the test node created by CommentTestBase::setUp().
+   *
+   * @var string
+   */
+  protected $nodeUri;
...
+    // Create node with single quotation mark title to ensure it does not get
+    // escaped more than once.
+    $this->node = $this->drupalCreateNode([
+      'type' => 'article',
+      'title' => $this->randomMachineName(8) . "'",
+    ]);
+

@@ -35,61 +66,51 @@ protected function setUp() {
+    // Prepares commonly used URIs.
+    $this->baseUri = Url::fromRoute('<front>', [], ['absolute' => TRUE])->toString();
+    $this->nodeUri = $this->node->toUrl('canonical', ['absolute' => TRUE])->toString();
...
-    // Create node with single quotation mark title to ensure it does not get
-    // escaped more than once.
-    $node = $this->drupalCreateNode([
-      'type' => 'article',
-      'title' => $this->randomMachineName(8) . "'",
-    ]);
-
-    $node_uri = $node->toUrl('canonical', ['absolute' => TRUE])->toString();
-    $base_uri = Url::fromRoute('<front>', [], ['absolute' => TRUE])->toString();
-
-    // Parses front page where the node is displayed in its teaser form.
-    $parser = new \EasyRdf_Parser_Rdfa();
-    $graph = new \EasyRdf_Graph();
-    $parser->parse($graph, $this->drupalGet('node/' . $node->id()), 'rdfa', $base_uri);
 

I don't think we need these changes, we can just keep the local variables in this test.

The class properties already existed in the Comment test, that's why I used them.

1. geez, FieldRdfaTestBase is a weird one, it looks like leftover debugging code, I think we should just do the following:

   
       $expected_rdf_value += ['type' => 'literal'];
   
       // The field formatter will be rendered inside the entity. Set the field
       // formatter in the entity display options before rendering the entity.
       \Drupal::service('entity_display.repository')
         ->getViewDisplay('entity_test', 'entity_test')
         ->setComponent($this->fieldName, $formatter)
         ->save();
       $build = \Drupal::entityTypeManager()
         ->getViewBuilder($this->entity->getEntityTypeId())
         ->view($this->entity, 'default');
       $output = \Drupal::service('renderer')->renderRoot($build);
   
       $this->assertTrue($this->hasRdfProperty($output, $this->uri,  $this->uri, $property, $expected_rdf_value), "Formatter {$formatter['type']} exposes data correctly for {$this->fieldType} fields.");
   
   

   and remove the $debug class property.

   what do you think @mondrake @andypost

2. +++ b/core/modules/rdf/tests/src/Functional/CommentAttributesTest.php
   @@ -307,17 +291,12 @@ public function _testBasicCommentRdfaMarkup($graph, CommentInterface $comment, $
   +      $author_uri = $this->getRdfNode($this->getSession()->getPage()->getContent(), $this->baseUri, $comment_uri, '<http://rdfs.org/sioc/ns#has_creator>');
   +      $this->assertTrue($author_uri->isBnode());
   

   thinking about it more, I think the ::isBNode call here (which is from my original patch) is wrong, cause that's easyrdf specific knowledge in the test, we need to keep that internal to the trait, probably a ::rdfElementIsBlank method on the trait

3. +++ b/core/modules/rdf/tests/src/Functional/StandardProfileTest.php
   @@ -205,10 +208,10 @@ public function testRdfaOutput() {
   +    $this->assertEqual(2, count($this->getRdfGraph(Url::fromRoute('<front>'), $this->baseUri)->allOfType('http://schema.org/Article')), 'Two articles found on front page.');
   

   because we still have an ::allOfType call here, we've still got a coupling to easyrdf - maybe we make the method ::getElementByRdfTypeCount i.e it returns 2 and does the allOfType call for us, keeping that internal to the trait - thoughts?

4. +++ b/core/modules/rdf/tests/src/Functional/StandardProfileTest.php
   @@ -244,25 +245,27 @@ protected function doFrontPageRdfaTests() {
   +    $this->assertEqual($this->getRdfGraph($this->article->toUrl(),$this->baseUri)->type($this->articleUri), 'schema:Article', 'Article type was found (schema:Article).');
   

   similar here, can we hoist the ::type call up into the trait so the test has no knowledge of easyrdf as a method - e.g. ::getElementRdfType?

5. +++ b/core/modules/rdf/tests/src/Functional/StandardProfileTest.php
   @@ -281,13 +284,13 @@ protected function doPageRdfaTests() {
   -    $graph = $this->getRdfGraph($this->page->toUrl());
   +    $graph = $this->getRdfGraph($this->page->toUrl(), $this->baseUri);
    
        // Type.
        $this->assertEqual($graph->type($this->pageUri), 'schema:WebPage', 'Page type was found (schema:WebPage).');
   
   @@ -297,7 +300,7 @@ protected function doUserRdfaTests() {
   -    $graph = $this->getRdfGraph($this->adminUser->toUrl());
   +    $graph = $this->getRdfGraph($this->adminUser->toUrl(), $this->baseUri);
    
        // User type.
        $this->assertEqual($graph->type($this->authorUri), 'schema:Person', "User type was found (schema:Person) on user page.");
   
   @@ -317,7 +320,7 @@ protected function doUserRdfaTests() {
   -    $graph = $this->getRdfGraph($this->term->toUrl());
   +    $graph = $this->getRdfGraph($this->term->toUrl(), $this->baseUri);
    
        // Term type.
        $this->assertEqual($graph->type($this->termUri), 'schema:Thing', "Term type was found (schema:Thing) on term page.");
   
   @@ -369,24 +373,24 @@ protected function assertRdfaCommonNodeProperties($graph, NodeInterface $node, $
   -    $this->assertEqual($graph->type($this->authorUri), 'schema:Person', "$message_prefix author type was found (schema:Person).");
   +    $this->assertEqual($this->getRdfGraph($node->toUrl(), $this->baseUri)->type($this->authorUri), 'schema:Person', "$message_prefix author type was found (schema:Person).");
   
   @@ -421,20 +425,19 @@ protected function assertRdfaArticleProperties($graph, $message_prefix) {
   -    $this->assertEqual($graph->type($this->articleCommentUri), 'schema:Comment', 'Comment type was found (schema:Comment).');
   +    $this->assertEqual($this->getRdfGraph($this->article->toUrl(),$this->baseUri)->type($this->articleCommentUri), 'schema:Comment', 'Comment type was found (schema:Comment).');
   
   @@ -462,24 +465,24 @@ protected function assertRdfaNodeCommentProperties($graph) {
   -    $this->assertEqual($graph->type($this->commenterUri), 'schema:Person', 'Comment author type was found (schema:Person).');
   +    $this->assertEqual($this->getRdfGraph($this->article->toUrl(),$this->baseUri)->type($this->commenterUri), 'schema:Person', 'Comment author type was found (schema:Person).');
   

   which we could re-use here too and avoid the ::getRdfGraph calls

   After that I think that means the trait will end up with only these four methods

   - hasRdfProperty
   - getElementByRdfTypeCount
   - getElementRdfType
   - rdfElementIsBlank

Which means we'll have to reimplement those 4 without easyrdf and we're done - thanks for moving this along @amjad

for 13.1 basically we remove the debug option and just use hasRdfProperty

I think this isolates all the easyrdf/easyrdf code into the trait

next step is to implement it without easyrdf

looking at the d7 code, it just uses xpath, so that seems like an approach

Then after that, we can follow https://www.drupal.org/node/3089540 to remove easyrdf from composer.lock and core/composer.json

Looking at the original issue where this was introduced, xpath was not sufficient for what we needed, so I guess we simplify and use DomDocument

Here's some progress, some passing tests with the new body, but only supported property attribute so far

Discussed with @amjad1233 and @alexpott.

Easyrdf has merged the PR to add PHP 7.4 support, but there is still merit in having all of our usages of easyrdf isolated to a trait.

As a result, we're pivoting this issue back to the patch in #20

Downgrading this to normal.

Crediting @alexpott for discussions around this

I wonder if instead we should add it to WebAssert and then we don't need the first argument and can then keep a reference to the graph item and only regenerate if the session has changed?