As i learnt from #3018109-4: Plan for Inline Entity Form 7.x-1.9 release, @joachim currently is the only active maintainer. So stepping up to give the module some more love.

I'm actively using this in some projects and the hubs4change distro and rolled some contrib module that complement the module, so although i have a tight schedule, i have some incentive and bandwidth to work on this.

Comments

geek.merlin aka axel.rutz created an issue. See original summary.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Title: Stepping up as comaintainer » Stepping up as 8.x comaintainer

To not set wrong expectations.

dww’s picture

dww
we/he/they
commented

+1. @geek.merlin aka axel.rutz is a very competent and careful contributor. IEF is an important module that lots of sites need. It'd be great to get more bandwidth on the (co)maintainer wagon. :)

Thanks for offering to help!
-Derek

joachim’s picture

joachim commented

Thanks for volunteering! I'd be very happy to have you on board as co-maintainer.

I don't have access to add you, so the best person to ask is bojanz.

In the meantime, do you want to make a start by reviewing #2974544: Convert tests from Simpletest to FunctionalJavascript? I am considering pretty much all development blocked on that issue, as we need to be able to test patches for such a complex module. We maybe need to also file an issue to review our test coverage; or at the very least be very mindful about whether the things any patch changes are properly covered by tests.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

OK let's go for this, really happy to work with you! (And: No, unfortunately i won't be in 'Dam ;-)

> ask bojanz.

OK will do that after some time passed.

> start by reviewing [modernize tests]

Yes i agree this is crucial. To set expectations, i'm not very fluent in writing tests, but hope to improve this while working on this module.

> We maybe need to also file an issue to review our test coverage;

+1

> or at the very least be very mindful about whether the things any patch changes are properly covered by tests.

Yeah we need to find some policy for that. My gut feeling is that we do not have the traction to have tests for every commit, but surely will develop some criteria.

I'd suggest to also make releases more robust by - after 1.0 - adopting the "minor RC" scheme that d.o now supports (we use that e.g. over at EVA): Have both 1.0 and 1.1-RC and only after some time mark 1.1 stable. What do you think?

joachim’s picture

joachim commented

> adopting the "minor RC" scheme that d.o now supports (we use that e.g. over at EVA): Have both 1.0 and 1.1-RC and only after some time mark 1.1 stable. What do you think?

Yes, that sounds like a very good plan if d.o now supports them.

Do you find that users try the RC releases?

> (And: No, unfortunately i won't be in 'Dam ;-)

I'm not either sadly.

oknate’s picture

oknate
Location Greater New York City Area
commented

if joachim is the only active maintainer, perhaps this procedure should be followed, so that joachim is a full maintainer with access to add others.

https://www.drupal.org/node/251466

Update: let's wait to see if bojanz writes back, see below.

oknate’s picture

oknate
Location Greater New York City Area
commented

I have written to bojanz. He's been very active on other projects in the last year, so he should be reachable.

bojanz’s picture

bojanz commented

Sorry, I'm no longer subscribed to issues in this queue, so I didn't see this.

I've given joachim full access. Leaving the honor of onboarding axel.rutz to him.

I also granted co-maintainership to oknate, his work on converting tests speaks for itself.

oknate’s picture

oknate
Location Greater New York City Area
commented

Thanks, bojanz!

joachim’s picture

joachim commented
Status: Active » Fixed

Thanks bojanz!

And done!

Welcome aboard, both of you!

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

OK so let's all rock on!

> Do you find that users try the RC releases?

Yes. People need feature X implemented or bug Y fixed, so they prefer RC over the well-hung version.
They know what they do, consenting adults and so, and don't blame you you broke their site.
Then if we have someting between 50 and 200 RC installs, we can say the new version is field tested and promote it to stable.
Having the installation numbers makes the difference. (And in the end, users find stuff we did not even think of testing ;-).

joachim’s picture

joachim commented

Good to know! Let's do that then!

chris matthews’s picture

chris matthews commented

What what it's worth, just wanted to say thank you to @bojanz for carrying the weight of this widely used module for so long and so glad to see @axel.rutz and @oknate joining up.

dww’s picture

dww
we/he/they
commented

@Chris Matthews re: #14

Absolutely! Huge thanks to @bojanz, @axel.rutz and @oknate for all of their countless contributions to this and other modules!!

Cheers,
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.