Problem/Motivation

After I upgraded from 8.6.16 to 8.7.8, I am getting null route for the requests made by big_pipe. Weird thing is, the problem is only occurring in our automated tests written using drupal-test-traits, but not when the path is visited from browser, therefore I am not able to write the exact steps to reproduce the problem.

These are some tests which are erroring.

- Travis build
- the test which is failing

CommentFileSizeAuthor
#2 3089913-2.patch1.18 KBsubhojit777

Comments

subhojit777 created an issue. See original summary.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
StatusFileSize
new 3089913-2.patch1.18 KB

I debugged the problem, and executed the test in my machine, and this is the test output I got:

layout_builder_system_breadcrumb_alter(Object, Object, Array) (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('system_breadcrumb', Object, Object, Array) (Line: 94)
Drupal\Core\Breadcrumb\BreadcrumbManager->build(Object) (Line: 72)
Drupal\system\Plugin\Block\SystemBreadcrumbBlock->build() (Line: 163)
Drupal\block\BlockViewBuilder::preRender(Array)
call_user_func('Drupal\block\BlockViewBuilder::preRender', Array) (Line: 378)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 450)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 195)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 151)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 582)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 152)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 166)
Drupal\Core\Render\Renderer->renderPlaceholder('', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('', Array) (Line: 434)
Drupal\big_pipe\Render\BigPipe->sendNoJsPlaceholders('', Array, Object) (Line: 336)
Drupal\big_pipe\Render\BigPipe->sendPreBody('', Array, Object) (Line: 304)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 374)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)

After making changes in layout_builder module, the tests worked. I am not sure whether the problem is in the big_pipe module, or the test framework.

Version: 8.7.8 » 8.7.x-dev

Core issues are now filed against the dev versions where changes will be made. Document the specific release you are using in your issue comment. More information about choosing a version.

Version: 8.7.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Branches prior to 8.8.x are not supported, and Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

josephdpurcell’s picture

josephdpurcell commented
Status: Active » Needs review
Related issues: +#3116623: Error: Call to a member function hasRequirement() on null, +#3158327: InvalidArgumentException while trying to render item (entityidhere) with view mode full for search index Acquia Search Solr Index: Route required in Drupal\Core\Url::fromRouteMatch(), +#3101533: Indexing a rendered entity which contains a breadcrumb using Search API results in a fatal error, +#3158332: InvalidArgumentException while trying to render item (entityidhere) with view mode full for search index Acquia Search Solr Index: Route required in Drupal\Core\Url::fromRouteMatch()

After applying the patch from #2 I was able to see the issue went away during indexing.

Adding issues in other modules and code that cause issues due to fromRouteMatch() throwing an exception.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Closed (duplicate)
Related issues: -#3116623: Error: Call to a member function hasRequirement() on null, -#3158327: InvalidArgumentException while trying to render item (entityidhere) with view mode full for search index Acquia Search Solr Index: Route required in Drupal\Core\Url::fromRouteMatch(), -#3101533: Indexing a rendered entity which contains a breadcrumb using Search API results in a fatal error, -#3158332: InvalidArgumentException while trying to render item (entityidhere) with view mode full for search index Acquia Search Solr Index: Route required in Drupal\Core\Url::fromRouteMatch()

This is a duplicate of #3104980: layout_builder_system_breadcrumb_alter doesn't check for a null route object