In css/src/components/skip-link.css:
The transform property is prefixed in the sourcecode:

  -webkit-transform: translateX(-50%);
  -ms-transform: translateX(-50%);
  transform: translateX(-50%);

This is redundant since autoprefixer already takes care of this in the dist folder.

Comments

martijn.cuppens created an issue. See original summary.

martijn.cuppens’s picture

StatusFileSize
new418 bytes
iro’s picture

Status: Active » Needs review
StatusFileSize
new1.04 KB

css/src/components/skip-link.css is the generated file and should not be edited directly.
css/src/components/skip-link.pcss.css is the source file where the changes should be done and then it should be compiled.
I am adding the patch.

cedric_a’s picture

I think this issue is no more relevant as the skip-link.pcss.css file is now correct in the Core (8.8.x) version of Claro.

lauriii’s picture

Title: CSS: Remove prefixed values in skip link source » Remove prefixed transform properties in skip link source
Project: Claro » Drupal core
Version: 8.x-2.x-dev » 8.9.x-dev
Component: Code » Claro theme
Status: Needs review » Needs work
Issue tags: +Needs reroll

This should be rerolled on top of Drupal core.

huzooka’s picture

Isn't it better to implement the new skip-link styles instead of just removing the legacy properties?

iro’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll

The patch at #3 was against the Core (8.8.x) version of Claro. The component is not correct as mentioned at #4.
I change the status and remove the Needs reroll tag since it is on top of Drupal core.

huzooka’s picture

Issue tags: +Novice, +Needs reroll
heykarthikwithu’s picture

StatusFileSize
new467 bytes

re-rolled the patch

huzooka’s picture

Status: Needs review » Needs work

Re #9:

@heykarthikwithu, you forgot to remove the -ms-transform: translateX(-50%); line :)

ravi.shankar’s picture

Status: Needs work » Needs review
StatusFileSize
new500 bytes

Here I have made changes as suggested in #10

huzooka’s picture

This is RTBC when #11 passes (it will 😊).

huzooka’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

As I predicted...

alexpott’s picture

Version: 8.9.x-dev » 8.8.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed df68b01146 to 9.0.x and c0a6ca5b56 to 8.9.x and 6740a58e2f to 8.8.x. Thanks!

Backported to 8.8.x as this doesn't actually affect run-time code - the results of processing the pcss file are the same and Claro is also experimental.

  • alexpott committed df68b01 on 9.0.x
    Issue #3089269 by martijn.cuppens, iro, heykarthikwithu, ravi.shankar,...

  • alexpott committed c0a6ca5 on 8.9.x
    Issue #3089269 by martijn.cuppens, iro, heykarthikwithu, ravi.shankar,...

  • alexpott committed 6740a58 on 8.8.x
    Issue #3089269 by martijn.cuppens, iro, heykarthikwithu, ravi.shankar,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.