Closed (fixed)
Project:
Webform
Version:
8.x-5.x-dev
Component:
Documentation
Priority:
Minor
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
21 Oct 2019 at 18:06 UTC
Updated:
17 Nov 2019 at 16:34 UTC
Jump to comment: Most recent
Comments
Comment #2
josephdpurcell commentedUpdating description to clarify.
A few requests:
hook_webform_submission_form_altershould use a module prefix like "myajaxform_". Also, the module file should be all lowercase like "myAjaxForm.module"my_ajax_form_callbackshould use the same module prefix as the hook alter$.fn.myCustomAjaxFormSubmitmust be defined as a jQuery function -- especially considering the InvokeCommand calls "myCustomAjaxFormSubmit"; either add a comment that explains why OR a comment that simply says it must be a jQuery function because that's how this worksif (argument) {? Maybe rename the variable from "argument" to something that explains what it is, is the value the same as the back-end variable "$field_values"?Comment #3
thhafner commentedThank you for the feedback. I have made updates to the cookbook page.
Comment #4
thhafner commentedComment #5
josephdpurcell commentedThis is great! A few follow up suggestions:
Of these suggestions, I think code style is the most important; the others are OK if you feel there's a good reason to keep as is.
Comment #6
thhafner commentedThanks for the feedback! Updated.
Comment #7
josephdpurcell commentedWonderful! Thank you for documenting this!
Comment #8
jrockowitz commented@thhafner Thank you for updating that recipe.