I get the following notice messages in the MailchimpSignupPageForm:

Notice: Undefined index: gdpr_consent in Drupal\mailchimp_signup\Form\MailchimpSignupPageForm->buildForm() (line 231 of modules/contrib/mailchimp/modules/mailchimp_signup/src/Form/MailchimpSignupPageForm.php).

Notice: Undefined index: ajax_submit in Drupal\mailchimp_signup\Form\MailchimpSignupPageForm->buildForm() (line 266 of modules/contrib/mailchimp/modules/mailchimp_signup/src/Form/MailchimpSignupPageForm.php).

CommentFileSizeAuthor
#16 mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-16.patch2.53 KBdeveloper-rocha
#15 mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-15.patch2.57 KBdeveloper-rocha
#11 interdiff_6_11.txt919 bytesunstatu
#11 mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-11.patch1.32 KBunstatu
#6 mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-6.patch1.07 KBOmar Alahmed
#3 mailchimp-check_if_gdpr_consent_and_ajax_submit_exist-13290071-3.patch1.21 KBInaW
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InaW created an issue. See original summary.

InaW’s picture

InaW CreditAttribution: InaW at Unic commented
Version: 8.x-1.11 » 8.x-1.x-dev
InaW’s picture

InaW CreditAttribution: InaW at Unic commented
Status: Active » Needs review
FileSize
mailchimp-check_if_gdpr_consent_and_ajax_submit_exist-13290071-3.patch1.21 KB

Attached I uploaded a patch that checks undefined keys before accessing them.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
CreditAttribution: samuel.mortenson commented
Status: Needs review » Fixed

LGTM, thanks @InaW!

  • InaW authored 4ab3fa8 on 8.x-1.x 
    Issue #3086453 by InaW: Notice: Undefined index in...
Omar Alahmed’s picture

Omar Alahmed
Primary language English
Location Jordan
CreditAttribution: Omar Alahmed at Vardot commented
Version: 8.x-1.x-dev » 8.x-1.11
FileSize
mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-6.patch1.07 KB

Re-roll #3 to work with 8.x-1.11 without the ajax submit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

astringer’s picture

astringer CreditAttribution: astringer commented

#6 works for me on 8.x-1.11, can we get this patch applied?

jakubmrozonline’s picture

jakubmrozonline CreditAttribution: jakubmrozonline commented

#6 worked for me as well.

JFeltkamp’s picture

JFeltkamp
Primary language German
Location Hamburg
CreditAttribution: JFeltkamp commented

#6 works, thanks for that

unstatu’s picture

unstatu CreditAttribution: unstatu commented
FileSize
mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-11.patch1.32 KB
interdiff_6_11.txt919 bytes

I had this problem as well but I got a new NOTICE error when I signed up.

This patch fixes it.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Will a new release of Mailchimp be issued to resolve this bug?

codesmith’s picture

codesmith
Location San Francisco
CreditAttribution: codesmith commented

@unstatu - this patch was already committed. Please open a new issue with your new patch - looks good! Thanks!

unstatu’s picture

unstatu CreditAttribution: unstatu commented

Thanks for the guidance @codesmith. As it was the same bug I was not sure if I should create a new issue for it. Even if it was already closed.

I have created the new issue in https://www.drupal.org/project/mailchimp/issues/3102045

developer-rocha’s picture

developer-rocha CreditAttribution: developer-rocha as a volunteer and commented
FileSize
mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-15.patch2.57 KB

The problem still happens in the version 8x1.12
Patch to fix it for this version:

developer-rocha’s picture

developer-rocha CreditAttribution: developer-rocha as a volunteer and commented
FileSize
mailchimp-notice-undefined-index-in-mailchimp_signup_page_form-3086453-16.patch2.53 KB

This patch works for the version 8x1.12