Closed (fixed)
Project:
Recurring Events
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Oct 2019 at 04:52 UTC
Updated:
1 Nov 2019 at 20:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
owenbush commentedThis is a weird one. Did you uninstall field group? Did you remove the groups before doing so? If you didn't uninstall field group did you remove the fields from the group prior to deleting the group? Have you cleared your caches since removing the group?
It might be worth scoping out the field group issue queue for similar problems as I find it difficult to believe this could be caused by recurring events. If it does prove to be RE, then I'll happily figure out a patch but that seems unlikely.
Comment #3
the_glitch commentedIt's been like this for at least a couple of weeks so I can't remember exactly what I did in that time but I'm pretty sure I didn't uninstall field_group at all.
I've just gone into a test install I've got. Each 'Include' and 'Exclude' date field have their own separate tabs in the form by default which don't appear in Manage Form Display so you can't remove them through the UI.

I created a new tab for both fields (which are in still in and put them in the tab and this is what I see in the form. They are still in their default tabs but the 'Include Exclude tab' tab I created doesn't appear in the form.
Also notice that the 'How' field group is now displaying on top of the Include and Exclude fields even though 'How' is underneath in Manage Form Display.
If there are field groups for these fields in the module itself I think those field groups need to be removed from module's code.

Comment #4
owenbush commentedThis module does not use field group at all, so there are no groups out of the box.
They are in their own 'details' container. A details container is basically a wrapper which allows them to be collapsible.
The problem here is that the details container is added in a form alter, so it would likely interfere with groups. I may just have to remove the collapsible part and accept that on default installations the form will be longer than hoped.
Comment #5
the_glitch commentedYes probably best to leave as many bells and whistles out so they don't clash with any of the installable bells and whistles in the drupal ecosystem that people are likely to use. Keep it as much of a functional skeleton as possible and let the builders flesh out the rest.
On the contrary this might be a bit of a stretch but, while we're kind of on the topic, I was thinking maybe the other conditional field sets in RE (eg Create Events Between Date and Date, Event Start Time, Event Duration etc) that are dependant on its parent fields (eg Daily or Weekly Event, Monthly Event, Custom Event radio buttons) might be able to have their animations controlled either by Conditional_fields animation controls with a plugin module so the animation controls from conditional_fields appear in th RE settings pages for the relevant RE fields?
Comment #6
the_glitch commenteddeleted
Comment #7
owenbush commentedAttached is a patch to remove the included/excluded dates from the collapsible details container.
Comment #8
the_glitch commentedpatch #7 works perfectly. Thank you.
Comment #9
owenbush commentedMoving to RTBC. I'll merge this soon.
Comment #11
owenbush commentedThis has now been merged into 8.x-1.x-dev.