Deprecated Code Report [#3084146]

php drupal-check.phar modules/contrib/single_page_site/
 8/8 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------- 
  Line   src/Controller/SinglePageSiteController.php         
 ------ ---------------------------------------------------- 
  77     Call to deprecated function drupal_get_messages().  
  120    Call to deprecated function drupal_set_message().   
 ------ ---------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/SinglePageSiteConfigForm.php              
 ------ --------------------------------------------------- 
  232    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors

Comment	File	Size	Author
#6	imported_class_error.patch	634 bytes	jussni
#3	3084146-drupal-9-support-3.patch	27.59 KB	nickdickinsonwilde
#2	deprecated-3084146-2.patch	1.37 KB	sergiu stici

Issue fork single_page_site-3084146

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2.x changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

27 September 2019 at 07:05

Sergiu Stici created an issue. See original summary.

Status	File	Size
new	deprecated-3084146-2.patch	1.37 KB

Comment #3

nickdickinsonwilde

He/Him/His

English

Victoria, BC (T'So-uke lands)

commented 24 May 2020 at 14:30

Status	File	Size
new	3084146-drupal-9-support-3.patch	27.59 KB

Since September, there have been.. a lot of changes.
New patch attached basically ignoring the old patch, so no interdiff. Due to symphony changes/core changes I recommend releasing this as a new major version - as with this patch it is *only* Drupal 9 compatible.

Comment #4

nickdickinsonwilde

He/Him/His

English

Victoria, BC (T'So-uke lands)

commented 24 May 2020 at 14:31

Issue tags:

+Drupal 9 compatibility, +Drupal 9 porting weekend

Comment #5

10 June 2020 at 08:54

NickDickinsonWilde authored e505870 on 9.x-1.x

Issue #3084146 by NickDickinsonWilde: Deprecated Code Report

Comment #6

jussni commented 30 August 2020 at 22:10

Status	File	Size
new	imported_class_error.patch	634 bytes

Hi, I have tested your d9.x-1.x branch and encountered this issue:

Got error 'PHP message: TypeError: Argument 2 passed to Drupal\\Component\\EventDispatcher\\ContainerAwareEventDispatcher::dispatch() must be an instance of Symfony\\Component\\EventDispatcher\\Event or null, instance of Drupal\\single_page_site\\Event\\EventSinglePageSiteAlterOutput given, called in /modules/single_page_site/src/Controller/SinglePageSiteController.php on line 127

After changing the imported class, it seems to work.