With the default setting for "Paths to replace with custom breadcrumbs", I'm finding with the current implementation it's always matching the homepage as a custom path to replace, as the homepage returns an empty path "".

We should remove empty values when generating the values for custom path overrides. When you currently leave the field empty it returns a single value of an empty string "", which matches the homepage path. This is leading to an unintended breadcrumb being generated for us.

Will supply a patch in a few minutes.

CommentFileSizeAuthor
#2 3083463-2-remove-empty-custom-path-overrides.patch575 bytesthomwilhelm

Comments

ThomWilhelm created an issue. See original summary.

thomwilhelm’s picture

thomwilhelm commented
StatusFileSize
new 3083463-2-remove-empty-custom-path-overrides.patch575 bytes

Patch attached.

thomwilhelm’s picture

thomwilhelm commented
Status: Active » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: thomwilhelm » Unassigned
jernejbeg’s picture

jernejbeg commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it works. I didn't notice any breaking changes while testing it on my local environment.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Worked has Excepted. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.