Problem/Motivation

Function field_group_group_delete is seen as a hook implementation of hook_ENTITY_TYPE_delete for the group entity provided by Group module

Proposed resolution

Inline this code into the form, it looks like legacy code anyway?

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

larowlan created an issue. See original summary.

swentel’s picture

swentel commented

Mmm yeah, this could probably be moved to FieldGroupDeleteForm::submitForm()

Or maybe rename so it doesn't collide? The module contains a couple of other functions that act as some sort of API for developers.

  • 59f9745 committed on 8.x-3.x 
    Issue #3082982: Function name collision with group module hook. Rename...
nils.destoop’s picture

nils.destoop commented
Status: Active » Fixed

Renaming is idd the best option, as this function is to help other users when they want to delete a field group via code. I committed a fix. The function is now 'field_group_delete_field_group'

nils.destoop’s picture

nils.destoop commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.