Node revisions: in paged lists, the first revision in any page is always marked as default [#3082614]

When the list of node revisions is paged, the first revision in every page is marked as being the default revision. The comments on the code suggest this is by design, to take into account multi-language revisions. In case there is only one language, we have solved this by adding an extra condition to verify where the node has translations or not.

Comment	File	Size	Author
#6	3082614-6.patch	992 bytes	ranjith_kumar_k_u
#5	3082614-d9_paged_revisions_first_element_always_current.patch	970 bytes	eadamse
	paged-revisions-first-in-page-always-default-fix.patch	983 bytes	raqfialho

Comments

Comment #1

20 September 2019 at 14:24

raqfialho created an issue. See original summary.

Comment #2

20 September 2019 at 14:24

Version:

8.7.6

» 8.7.x-dev

Core issues are now filed against the dev versions where changes will be made. Document the specific release you are using in your issue comment. More information about choosing a version.

Comment #3

20 September 2019 at 14:24

Version:

8.7.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Branches prior to 8.8.x are not supported, and Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #4

20 September 2019 at 14:24

Version:

8.9.x-dev

» 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #5

eadamse commented 12 January 2022 at 21:16

Status:

Needs work

» Needs review

Status	File	Size
new	3082614-d9_paged_revisions_first_element_always_current.patch	970 bytes

Original patch applied cleanly for me on 9.2.x.

Re-roll/uploading for testing.

Comment #6

ranjith_kumar_k_u commented 13 January 2022 at 12:13

Status	File	Size
new	3082614-6.patch	992 bytes

Comment #7

13 January 2022 at 13:12

Status:

Needs review

» Needs work

The last submitted patch, 6: 3082614-6.patch, failed testing. View results

Comment #8

13 January 2022 at 13:12

Version:

9.2.x-dev

» 9.3.x-dev

Comment #9

mediabounds commented 16 January 2022 at 01:20

The patches above assume that the default revision on a node is displayed in the revisions table--but the revisions table filters to only show revisions where the the current translation is affected. This is what the failing test in NodeRevisionsUiTest is showing. (Plus, it doesn't fix the issue if translations _are_ enabled on a node.)

There is an identical bug reported in #3021671: Node revisions tab have "Current Version" on every Page; I've added a patch there which fixes the issue (and passes tests).